linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: Phillip Susi <psusi@ubuntu.com>, Daniele Testa <daniele.testa@gmail.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: btrfs is using 25% more disk than it should
Date: Fri, 19 Dec 2014 17:06:10 -0500	[thread overview]
Message-ID: <5494A152.7030203@fb.com> (raw)
In-Reply-To: <54949E60.7010201@ubuntu.com>

On 12/19/2014 04:53 PM, Phillip Susi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 12/19/2014 4:15 PM, Josef Bacik wrote:
>> Please God don't turn off of checksums.  Checksums are tracked in
>> metadata anyway, they won't show up in the data accounting.  Our
>> csums are 8 bytes per block, so basic math says you are going to
>> max out at 604 megabytes for that big of a file.
>
> Yes, and it is exactly that metadata space he is complaining about.
> So if you don't want to use up all of that space ( and have no use for
> the checksums ), then you turn them off.
>
>> Please people try to only take advice from people who know what
>> they are talking about.  So unless it's from somebody who has
>> commits in btrfs/btrfs-progs take their feedback with a grain of
>> salt.  Thanks,
>
> Well that is rather arrogant and rude.  For that matter, I *do* have
> commits in btrfs-progs.
>

root@destiny ~/btrfs-progs# git log --oneline --author="Phillip Susi"
c65345d btrfs-progs: document --rootdir mkfs switch
f6b6e93 btrfs-progs: removed extraneous whitespace from mkfs man page

Sorry I should have qualified that statement better.

So unless it's from somebody who has had commits to meaningful portions 
of btrfs/btrfs-progs take their feedback with a grain of salt.

There are too many people on this list who give random horribly wrong 
advice to users that can result in data loss or corruption.  Now I'll 
admit I read her question wrong so what you said wasn't incorrect, I'm 
sorry for that.  I've seen a lot of people responding to questions 
recently that I don't recognize that have been completely full of crap, 
I just assumed you were in that camp as well.  Thanks,

Josef

  reply	other threads:[~2014-12-19 22:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 14:59 btrfs is using 25% more disk than it should Daniele Testa
2014-12-19 18:53 ` Phillip Susi
2014-12-19 19:59   ` Daniele Testa
2014-12-19 20:35     ` Phillip Susi
2014-12-19 21:15     ` Josef Bacik
2014-12-19 21:53       ` Phillip Susi
2014-12-19 22:06         ` Josef Bacik [this message]
2014-12-20  1:33     ` Duncan
2014-12-19 21:10 ` Josef Bacik
2014-12-19 21:17   ` Josef Bacik
2014-12-20  1:38     ` Duncan
2014-12-20  5:52     ` Zygo Blaxell
2014-12-20  6:18       ` Daniele Testa
2014-12-20  6:59         ` Duncan
2014-12-20 11:02         ` Josef Bacik
2014-12-20 11:28       ` Josef Bacik
2014-12-23 21:51         ` Zygo Blaxell
2014-12-20  9:15     ` Daniele Testa
2014-12-20 11:23     ` Robert White
2014-12-20 11:39       ` Josef Bacik
2014-12-21  1:40         ` Robert White
2014-12-21  3:04   ` Robert White

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5494A152.7030203@fb.com \
    --to=jbacik@fb.com \
    --cc=daniele.testa@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=psusi@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).