* [PATCH] btrfs-progs: Documentation: add T/P/E description for resize cmd @ 2014-12-22 2:01 Gui Hecheng 2014-12-22 3:20 ` Satoru Takeuchi 0 siblings, 1 reply; 10+ messages in thread From: Gui Hecheng @ 2014-12-22 2:01 UTC (permalink / raw) To: linux-btrfs; +Cc: Gui Hecheng Signed-off-by: Gui Hecheng <guihc.fnst@cn.fujitsu.com> --- Documentation/btrfs-filesystem.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/btrfs-filesystem.txt b/Documentation/btrfs-filesystem.txt index a8f2972..f2bd50d 100644 --- a/Documentation/btrfs-filesystem.txt +++ b/Documentation/btrfs-filesystem.txt @@ -102,8 +102,8 @@ If the prefix + or - is present the size is increased or decreased by the quantity <size>. If no units are specified, the unit of the <size> parameter defaults to bytes. Optionally, the size parameter may be suffixed by one of the following -units designators: \'K\', \'M', or \'G', kilobytes, megabytes, or gigabytes, -respectively. +units designators: \'K\'(KiB), \'M\'(MiB), \'G\'(GiB), \'T\'(TiB), \'P\'(PiB), +\'E\'(EiB). + If \'max' is passed, the filesystem will occupy all available space on the device devid. -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] btrfs-progs: Documentation: add T/P/E description for resize cmd 2014-12-22 2:01 [PATCH] btrfs-progs: Documentation: add T/P/E description for resize cmd Gui Hecheng @ 2014-12-22 3:20 ` Satoru Takeuchi 2014-12-22 7:22 ` [PATCH v2] " Gui Hecheng 0 siblings, 1 reply; 10+ messages in thread From: Satoru Takeuchi @ 2014-12-22 3:20 UTC (permalink / raw) To: Gui Hecheng, linux-btrfs On 2014/12/22 11:01, Gui Hecheng wrote: > Signed-off-by: Gui Hecheng <guihc.fnst@cn.fujitsu.com> > --- > Documentation/btrfs-filesystem.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/btrfs-filesystem.txt b/Documentation/btrfs-filesystem.txt > index a8f2972..f2bd50d 100644 > --- a/Documentation/btrfs-filesystem.txt > +++ b/Documentation/btrfs-filesystem.txt > @@ -102,8 +102,8 @@ If the prefix + or - is present the size is increased or decreased > by the quantity <size>. > If no units are specified, the unit of the <size> parameter defaults to > bytes. Optionally, the size parameter may be suffixed by one of the following > -units designators: \'K\', \'M', or \'G', kilobytes, megabytes, or gigabytes, > -respectively. > +units designators: \'K\'(KiB), \'M\'(MiB), \'G\'(GiB), \'T\'(TiB), \'P\'(PiB), > +\'E\'(EiB). Just a minor point. s/\'E\'(EiB)/or \'E\'(EiB)/ is better. Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> Thanks, Satoru > + > If \'max' is passed, the filesystem will occupy all available space on the > device devid. > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] btrfs-progs: Documentation: add T/P/E description for resize cmd 2014-12-22 3:20 ` Satoru Takeuchi @ 2014-12-22 7:22 ` Gui Hecheng 2014-12-29 16:07 ` David Sterba 0 siblings, 1 reply; 10+ messages in thread From: Gui Hecheng @ 2014-12-22 7:22 UTC (permalink / raw) To: linux-btrfs; +Cc: takeuchi_satoru, Gui Hecheng Signed-off-by: Gui Hecheng <guihc.fnst@cn.fujitsu.com> Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> --- changelog v1->v2: s/\'E\'(EiB)/or \'E\'(EiB)/ as suggested by Satoru, thanks. --- Documentation/btrfs-filesystem.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/btrfs-filesystem.txt b/Documentation/btrfs-filesystem.txt index a8f2972..138ba6c 100644 --- a/Documentation/btrfs-filesystem.txt +++ b/Documentation/btrfs-filesystem.txt @@ -102,8 +102,8 @@ If the prefix + or - is present the size is increased or decreased by the quantity <size>. If no units are specified, the unit of the <size> parameter defaults to bytes. Optionally, the size parameter may be suffixed by one of the following -units designators: \'K\', \'M', or \'G', kilobytes, megabytes, or gigabytes, -respectively. +units designators: \'K\'(KiB), \'M\'(MiB), \'G\'(GiB), \'T\'(TiB), \'P\'(PiB) +or \'E\'(EiB). + If \'max' is passed, the filesystem will occupy all available space on the device devid. -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] btrfs-progs: Documentation: add T/P/E description for resize cmd 2014-12-22 7:22 ` [PATCH v2] " Gui Hecheng @ 2014-12-29 16:07 ` David Sterba 2014-12-30 1:23 ` Gui Hecheng 2014-12-30 1:52 ` [PATCH v3] " Gui Hecheng 0 siblings, 2 replies; 10+ messages in thread From: David Sterba @ 2014-12-29 16:07 UTC (permalink / raw) To: Gui Hecheng; +Cc: linux-btrfs, takeuchi_satoru On Mon, Dec 22, 2014 at 03:22:53PM +0800, Gui Hecheng wrote: > Signed-off-by: Gui Hecheng <guihc.fnst@cn.fujitsu.com> > Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> > --- > changelog > v1->v2: s/\'E\'(EiB)/or \'E\'(EiB)/ as suggested by Satoru, thanks. > --- > Documentation/btrfs-filesystem.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/btrfs-filesystem.txt b/Documentation/btrfs-filesystem.txt > index a8f2972..138ba6c 100644 > --- a/Documentation/btrfs-filesystem.txt > +++ b/Documentation/btrfs-filesystem.txt > @@ -102,8 +102,8 @@ If the prefix + or - is present the size is increased or decreased > by the quantity <size>. > If no units are specified, the unit of the <size> parameter defaults to > bytes. Optionally, the size parameter may be suffixed by one of the following > -units designators: \'K\', \'M', or \'G', kilobytes, megabytes, or gigabytes, > -respectively. > +units designators: \'K\'(KiB), \'M\'(MiB), \'G\'(GiB), \'T\'(TiB), \'P\'(PiB) > +or \'E\'(EiB). I find this a bit confusing as this would suggest that eg. $ btrfs fi resize -1GiB is valid. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] btrfs-progs: Documentation: add T/P/E description for resize cmd 2014-12-29 16:07 ` David Sterba @ 2014-12-30 1:23 ` Gui Hecheng 2014-12-30 1:52 ` [PATCH v3] " Gui Hecheng 1 sibling, 0 replies; 10+ messages in thread From: Gui Hecheng @ 2014-12-30 1:23 UTC (permalink / raw) To: dsterba; +Cc: linux-btrfs, takeuchi_satoru On Mon, 2014-12-29 at 17:07 +0100, David Sterba wrote: > On Mon, Dec 22, 2014 at 03:22:53PM +0800, Gui Hecheng wrote: > > Signed-off-by: Gui Hecheng <guihc.fnst@cn.fujitsu.com> > > Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> > > --- > > changelog > > v1->v2: s/\'E\'(EiB)/or \'E\'(EiB)/ as suggested by Satoru, thanks. > > --- > > Documentation/btrfs-filesystem.txt | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/btrfs-filesystem.txt b/Documentation/btrfs-filesystem.txt > > index a8f2972..138ba6c 100644 > > --- a/Documentation/btrfs-filesystem.txt > > +++ b/Documentation/btrfs-filesystem.txt > > @@ -102,8 +102,8 @@ If the prefix + or - is present the size is increased or decreased > > by the quantity <size>. > > If no units are specified, the unit of the <size> parameter defaults to > > bytes. Optionally, the size parameter may be suffixed by one of the following > > -units designators: \'K\', \'M', or \'G', kilobytes, megabytes, or gigabytes, > > -respectively. > > +units designators: \'K\'(KiB), \'M\'(MiB), \'G\'(GiB), \'T\'(TiB), \'P\'(PiB) > > +or \'E\'(EiB). > > I find this a bit confusing as this would suggest that eg. > > $ btrfs fi resize -1GiB > > is valid. Oh, you're right, thanks for pointing it out, then I'll just follow the old way and send a new one. -Gui > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] btrfs-progs: Documentation: add T/P/E description for resize cmd 2014-12-29 16:07 ` David Sterba 2014-12-30 1:23 ` Gui Hecheng @ 2014-12-30 1:52 ` Gui Hecheng 2015-01-02 3:27 ` Chris Murphy 1 sibling, 1 reply; 10+ messages in thread From: Gui Hecheng @ 2014-12-30 1:52 UTC (permalink / raw) To: dsterba; +Cc: linux-btrfs, takeuchi_satoru, Gui Hecheng Signed-off-by: Gui Hecheng <guihc.fnst@cn.fujitsu.com> Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> --- changelog v1->v2: s/\'E\'(EiB)/or \'E\'(EiB)/ as suggested by Satoru, thanks. v2->v3: replace confusing format 'K'(KiB) etc. Thanks, David. --- Documentation/btrfs-filesystem.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/btrfs-filesystem.txt b/Documentation/btrfs-filesystem.txt index a8f2972..96c4420 100644 --- a/Documentation/btrfs-filesystem.txt +++ b/Documentation/btrfs-filesystem.txt @@ -102,8 +102,9 @@ If the prefix + or - is present the size is increased or decreased by the quantity <size>. If no units are specified, the unit of the <size> parameter defaults to bytes. Optionally, the size parameter may be suffixed by one of the following -units designators: \'K\', \'M', or \'G', kilobytes, megabytes, or gigabytes, -respectively. +units designators: \'K\', \'M\', \'G\', \'T\', \'P\', or \'E\', which represent +KiB, MiB, GiB, TiB, PiB, or EiB, respectively. + + If \'max' is passed, the filesystem will occupy all available space on the device devid. -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3] btrfs-progs: Documentation: add T/P/E description for resize cmd 2014-12-30 1:52 ` [PATCH v3] " Gui Hecheng @ 2015-01-02 3:27 ` Chris Murphy 2015-01-02 16:12 ` David Sterba 0 siblings, 1 reply; 10+ messages in thread From: Chris Murphy @ 2015-01-02 3:27 UTC (permalink / raw) To: Gui Hecheng; +Cc: dsterba, Btrfs BTRFS, takeuchi_satoru On Mon, Dec 29, 2014 at 6:52 PM, Gui Hecheng <guihc.fnst@cn.fujitsu.com> wrote: > Signed-off-by: Gui Hecheng <guihc.fnst@cn.fujitsu.com> > Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> > --- > changelog > v1->v2: > s/\'E\'(EiB)/or \'E\'(EiB)/ as suggested by Satoru, thanks. > v2->v3: > replace confusing format 'K'(KiB) etc. Thanks, David. > --- > Documentation/btrfs-filesystem.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/btrfs-filesystem.txt b/Documentation/btrfs-filesystem.txt > index a8f2972..96c4420 100644 > --- a/Documentation/btrfs-filesystem.txt > +++ b/Documentation/btrfs-filesystem.txt > @@ -102,8 +102,9 @@ If the prefix + or - is present the size is increased or decreased > by the quantity <size>. > If no units are specified, the unit of the <size> parameter defaults to > bytes. Optionally, the size parameter may be suffixed by one of the following > -units designators: \'K\', \'M', or \'G', kilobytes, megabytes, or gigabytes, > -respectively. > +units designators: \'K\', \'M\', \'G\', \'T\', \'P\', or \'E\', which represent > +KiB, MiB, GiB, TiB, PiB, or EiB, respectively. > + > + > If \'max' is passed, the filesystem will occupy all available space on the > device devid. Small problem with the rendering of this commit d4ef1a06f8be623ae94e4d498c306e8dd1605bef, when I use 'man btrfs filesystem' the above portion looks like this: 'K', 'M', 'G', 'T', 'P', or 'E\', I'm not sure why there's a trailing slash after the E. Separately, for -t option, it reads: For <start>, <len>, <size> it is possible to append a suffix like k for 1 KBytes, m for 1 MBytes... So there's a reference of small k and m there, but then later references for capitalized KMGTPE, so maybe the reference could be more like e.g. LVM where it's described as [bBsSkKmMgGtTpPeE] and just omit the sS for sectors since this isn't supported. -- Chris Murphy ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] btrfs-progs: Documentation: add T/P/E description for resize cmd 2015-01-02 3:27 ` Chris Murphy @ 2015-01-02 16:12 ` David Sterba 2015-01-02 16:21 ` David Sterba 0 siblings, 1 reply; 10+ messages in thread From: David Sterba @ 2015-01-02 16:12 UTC (permalink / raw) To: Chris Murphy; +Cc: Gui Hecheng, dsterba, Btrfs BTRFS, takeuchi_satoru On Thu, Jan 01, 2015 at 08:27:55PM -0700, Chris Murphy wrote: > Small problem with the rendering of this commit > d4ef1a06f8be623ae94e4d498c306e8dd1605bef, when I use 'man btrfs > filesystem' the above portion looks like this: > > 'K', 'M', 'G', 'T', 'P', or 'E\', > > I'm not sure why there's a trailing slash after the E. Me neither, but it looks like a bug in the asciidoc processing, ends up in the intermediate xml output. I'll probably drop/change the quoting. > Separately, for -t option, it reads: > For <start>, <len>, <size> it is possible to append a suffix like k > for 1 KBytes, m for 1 MBytes... > > So there's a reference of small k and m there, but then later > references for capitalized KMGTPE, so maybe the reference could be > more like e.g. LVM where it's described as [bBsSkKmMgGtTpPeE] and just > omit the sS for sectors since this isn't supported. Yep, this should be unified. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] btrfs-progs: Documentation: add T/P/E description for resize cmd 2015-01-02 16:12 ` David Sterba @ 2015-01-02 16:21 ` David Sterba 2015-01-05 1:42 ` Gui Hecheng 0 siblings, 1 reply; 10+ messages in thread From: David Sterba @ 2015-01-02 16:21 UTC (permalink / raw) To: dsterba, Chris Murphy, Gui Hecheng, Btrfs BTRFS, takeuchi_satoru On Fri, Jan 02, 2015 at 05:12:04PM +0100, David Sterba wrote: > On Thu, Jan 01, 2015 at 08:27:55PM -0700, Chris Murphy wrote: > > Small problem with the rendering of this commit > > d4ef1a06f8be623ae94e4d498c306e8dd1605bef, when I use 'man btrfs > > filesystem' the above portion looks like this: > > > > 'K', 'M', 'G', 'T', 'P', or 'E\', > > > > I'm not sure why there's a trailing slash after the E. > > Me neither, but it looks like a bug in the asciidoc processing. Seems that only the first ' has to be quoted, and consumes the next unquoted ' as a pair, so with the last \' the next one is missing and is printed verbatim: Fixed by: -units designators: \'K\', \'M\', \'G\', \'T\', \'P\', or \'E\', which represent +units designators: \'K', \'M', \'G', \'T', \'P', or \'E', which represent ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3] btrfs-progs: Documentation: add T/P/E description for resize cmd 2015-01-02 16:21 ` David Sterba @ 2015-01-05 1:42 ` Gui Hecheng 0 siblings, 0 replies; 10+ messages in thread From: Gui Hecheng @ 2015-01-05 1:42 UTC (permalink / raw) To: dsterba; +Cc: Chris Murphy, Btrfs BTRFS, takeuchi_satoru On Fri, 2015-01-02 at 17:21 +0100, David Sterba wrote: > On Fri, Jan 02, 2015 at 05:12:04PM +0100, David Sterba wrote: > > On Thu, Jan 01, 2015 at 08:27:55PM -0700, Chris Murphy wrote: > > > Small problem with the rendering of this commit > > > d4ef1a06f8be623ae94e4d498c306e8dd1605bef, when I use 'man btrfs > > > filesystem' the above portion looks like this: > > > > > > 'K', 'M', 'G', 'T', 'P', or 'E\', > > > > > > I'm not sure why there's a trailing slash after the E. > > > > Me neither, but it looks like a bug in the asciidoc processing. > > Seems that only the first ' has to be quoted, and consumes the next > unquoted ' as a pair, so with the last \' the next one is missing and > is printed verbatim: > > Fixed by: > > -units designators: \'K\', \'M\', \'G\', \'T\', \'P\', or \'E\', which represent > +units designators: \'K', \'M', \'G', \'T', \'P', or \'E', which represent > Oh, sorry, I missed this problem, thanks for fixing it. -Gui ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-01-05 1:44 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-12-22 2:01 [PATCH] btrfs-progs: Documentation: add T/P/E description for resize cmd Gui Hecheng 2014-12-22 3:20 ` Satoru Takeuchi 2014-12-22 7:22 ` [PATCH v2] " Gui Hecheng 2014-12-29 16:07 ` David Sterba 2014-12-30 1:23 ` Gui Hecheng 2014-12-30 1:52 ` [PATCH v3] " Gui Hecheng 2015-01-02 3:27 ` Chris Murphy 2015-01-02 16:12 ` David Sterba 2015-01-02 16:21 ` David Sterba 2015-01-05 1:42 ` Gui Hecheng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).