From: Miao Xie <miaoxie@huawei.com>
To: Gui Hecheng <guihc.fnst@cn.fujitsu.com>, <linux-btrfs@vger.kernel.org>
Cc: Qu Wenruo <quwenruo@cn.fujitsu.com>
Subject: Re: [PATCH] btrfs: fix raid56 scrub failed in xfstests btrfs/072
Date: Fri, 9 Jan 2015 13:31:37 +0800 [thread overview]
Message-ID: <54AF67B9.7020703@huawei.com> (raw)
In-Reply-To: <1420767580-19380-1-git-send-email-guihc.fnst@cn.fujitsu.com>
On Fri, 09 Jan 2015 09:39:40 +0800, Gui Hecheng wrote:
> The xfstests btrfs/072 reports uncorrectable read errors in dmesg,
> because scrub forgets to use commit_root for parity scrub routine
> and scrub attempts to scrub those extents items whose contents are
> not fully on disk.
>
> To fix it, we just add the @search_commit_root flag back.
Reviewed-by: Miao Xie <miaoxie@huawei.com>
>
> Signed-off-by: Gui Hecheng <guihc.fnst@cn.fujitsu.com>
> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
> ---
> fs/btrfs/scrub.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
> index f2bb13a..aa8ff75 100644
> --- a/fs/btrfs/scrub.c
> +++ b/fs/btrfs/scrub.c
> @@ -3065,6 +3065,8 @@ static noinline_for_stack int scrub_stripe(struct scrub_ctx *sctx,
> path->search_commit_root = 1;
> path->skip_locking = 1;
>
> + ppath->search_commit_root = 1;
> + ppath->skip_locking = 1;
> /*
> * trigger the readahead for extent tree csum tree and wait for
> * completion. During readahead, the scrub is officially paused
>
next prev parent reply other threads:[~2015-01-09 5:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 1:39 [PATCH] btrfs: fix raid56 scrub failed in xfstests btrfs/072 Gui Hecheng
2015-01-09 5:31 ` Miao Xie [this message]
2015-01-16 11:00 ` David Sterba
2015-01-23 1:56 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AF67B9.7020703@huawei.com \
--to=miaoxie@huawei.com \
--cc=guihc.fnst@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).