From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Cc: <dsterba@suse.cz>
Subject: Re: [PATCH v4 0/8] Fix freeze/sysfs deadlock in better method.
Date: Thu, 29 Jan 2015 10:21:21 +0800 [thread overview]
Message-ID: <54C99921.4040808@cn.fujitsu.com> (raw)
In-Reply-To: <1422494863-15077-1-git-send-email-quwenruo@cn.fujitsu.com>
Oh, I'm very sorry for the patchset which includes other
unrelated/out-of-date patches.
I'll resend them with correct patchese.
Thanks,
Qu
-------- Original Message --------
Subject: [PATCH v4 0/8] Fix freeze/sysfs deadlock in better method.
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Date: 2015年01月29日 09:27
> Patchset to solve the previous found freeze/sysfs deadlock.
>
> Unlike previous pending_changes, which uses transaction commits to
> ensure mount option doesn't change during transaction.
> This idea is great in concept, but will introduce extra and somewhat
> duplicated ro/freeze check, and the original synchronized behavior is
> also changed.
>
> [Per-transaction mount option]
> This patch use the RCU-like concept, which will copy the mount_opt from
> fs_info into btrfs_transaction, and each btrfs_test_opt() for specific
> mount option bit(SPACE_CACHE/INODE_MAP_CACHE) should be changed to
> btrfs_test_trans_opt().
> So mount option during transaction won't be changed, and also, no extra
> read_only or freeze check is needed, the commit routine is also
> untouched.
>
> [Use VFS protect for sysfs change]
> The 6th patch will introduce a new help function get_vfsmount_sb() to
> get a vfsmount from a sb, with this vfsmount, we can use vfs level
> mnt_want_write() to do a comprehensive protection other than the cheap
> ro/freeze check.
>
> Qu Wenruo (8):
> Revert "btrfs: add support for processing pending changes" related
> commits
> btrfs: Make btrfs_parse_options() parse mount option in a atomic way
> btrfs: Introduce per-transaction mount_opt to keep mount option
> consistent during transaction.
> btrfs: Use btrfs_test_trans_opt() to handle SPACE_CACHE if it's under
> transaction protect.
> btrfs: Use btrfs_test_trans_opt() to handle INODE_CACHE if it's under
> transaction protect.
> vfs: Add get_vfsmount_sb() function to get vfsmount from a given sb.
> btrfs: Use mnt_want_write() to protect label change.
> btrfs: Use mnt_want_write() to protect sysfs feature change.
>
> fs/btrfs/ctree.h | 64 +++-------------------
> fs/btrfs/disk-io.c | 6 ---
> fs/btrfs/extent-tree.c | 2 +-
> fs/btrfs/free-space-cache.c | 2 +-
> fs/btrfs/inode-map.c | 5 +-
> fs/btrfs/super.c | 129 ++++++++++++++++++++++----------------------
> fs/btrfs/sysfs.c | 73 ++++++++++++++++++-------
> fs/btrfs/transaction.c | 43 ++-------------
> fs/btrfs/transaction.h | 6 ++-
> fs/namespace.c | 25 +++++++++
> include/linux/mount.h | 1 +
> 11 files changed, 167 insertions(+), 189 deletions(-)
>
prev parent reply other threads:[~2015-01-29 2:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 1:27 [PATCH v4 0/8] Fix freeze/sysfs deadlock in better method Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 1/8] Revert "btrfs: add support for processing pending changes" related commits Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 2/8] btrfs: Introduce per-transaction mount_opt to keep mount option consistent during transaction Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 2/8] btrfs: Make btrfs_parse_options() parse mount option in a atomic way Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 3/8] btrfs: Introduce per-transaction mount_opt to keep mount option consistent during transaction Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 3/8] btrfs: Use btrfs_test_trans_opt() to handle SPACE_CACHE if it's under transaction protect Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 4/8] btrfs: Use btrfs_test_trans_opt() to handle INODE_CACHE " Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 4/8] btrfs: Use btrfs_test_trans_opt() to handle SPACE_CACHE " Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 5/8] btrfs: Make btrfs_parse_options() parse mount option in a atomic way Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 5/8] btrfs: Use btrfs_test_trans_opt() to handle INODE_CACHE if it's under transaction protect Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 6/8] vfs: Add get_vfsmount_sb() function to get vfsmount from a given sb Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 7/8] btrfs: Use mnt_want_write() to protect label change Qu Wenruo
2015-01-29 1:27 ` [PATCH v4 8/8] btrfs: Use mnt_want_write() to protect sysfs feature change Qu Wenruo
2015-01-29 2:21 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C99921.4040808@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).