From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:28050 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754661AbbBLDWq (ORCPT ); Wed, 11 Feb 2015 22:22:46 -0500 Message-ID: <54DC1C7E.6050309@oracle.com> Date: Thu, 12 Feb 2015 11:22:38 +0800 From: Anand Jain MIME-Version: 1.0 To: dsterba@suse.cz, linux-btrfs@vger.kernel.org, clm@fb.com Subject: Re: [PATCH 22/24] Btrfs: sysfs: don't fail seeding for the sake of sysfs kobject issue References: <1423439785-10260-1-git-send-email-anand.jain@oracle.com> <1423439785-10260-23-git-send-email-anand.jain@oracle.com> <20150211184057.GJ28877@twin.jikos.cz> In-Reply-To: <20150211184057.GJ28877@twin.jikos.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 02/12/2015 02:40 AM, David Sterba wrote: > On Mon, Feb 09, 2015 at 07:56:23AM +0800, Anand Jain wrote: >> Signed-off-by: Anand Jain >> --- >> fs/btrfs/volumes.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c >> index 51873ec..1490723 100644 >> --- a/fs/btrfs/volumes.c >> +++ b/fs/btrfs/volumes.c >> @@ -2249,7 +2249,8 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path) >> root->fs_info->fsid); >> if (kobject_rename(&root->fs_info->fs_devices->super_kobj, >> fsid_buf)) >> - goto error_trans; >> + printk(KERN_WARNING\ >> + "BTRFS: sysfs: failed to create fsid for sprout\n"); > > You can safely use btrfs_warn here. > right. I tried to know what to use before, but wasn't sure. would you be able to accept it as it is ? OR I can send a new patch to correct this. Just that changing this commit would fail further commits like Btrfs: sysfs: support seed devices in the sysfs layout. Thanks, Anand