From: Nikolay Borisov <nborisov@suse.com>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Remove unused variable mode in btrfs_mount
Date: Fri, 5 Oct 2018 15:27:38 +0300 [thread overview]
Message-ID: <5504b456-039a-829c-1de4-b3d5a8dd0df2@suse.com> (raw)
In-Reply-To: <20181005122615.da52bp6a6ie4jzzw@merlin>
On 5.10.2018 15:26, Goldwyn Rodrigues wrote:
> Code cleanup.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
>
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index e7f702761cb7..f7b8b7a6b86a 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -1661,14 +1661,10 @@ static struct dentry *btrfs_mount(struct file_system_type *fs_type, int flags,
> {
> struct vfsmount *mnt_root;
> struct dentry *root;
> - fmode_t mode = FMODE_READ;
> char *subvol_name = NULL;
> u64 subvol_objectid = 0;
> int error = 0;
>
> - if (!(flags & SB_RDONLY))
> - mode |= FMODE_WRITE;
> -
> error = btrfs_parse_subvol_options(data, &subvol_name,
> &subvol_objectid);
> if (error) {
>
next prev parent reply other threads:[~2018-10-05 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 12:26 [PATCH] btrfs: Remove unused variable mode in btrfs_mount Goldwyn Rodrigues
2018-10-05 12:27 ` Nikolay Borisov [this message]
2018-10-08 13:03 ` David Sterba
2018-10-08 14:44 ` Goldwyn Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5504b456-039a-829c-1de4-b3d5a8dd0df2@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).