From: Eric Sandeen <sandeen@redhat.com>
To: Chris Mason <clm@fb.com>
Cc: fdmanana@gmail.com, linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: I think "btrfs: fix leak of path in btrfs_find_item" broke stable trees ...
Date: Thu, 26 Mar 2015 12:11:51 -0500 [thread overview]
Message-ID: <55143DD7.2020608@redhat.com> (raw)
In-Reply-To: <1427381284.28930.5@mail.thefacebook.com>
On 3/26/15 9:48 AM, Chris Mason wrote:
> On Thu, Mar 26, 2015 at 10:11 AM, Eric Sandeen <sandeen@redhat.com> wrote:
...
>>>> 9c4f61f btrfs: simplify insert_orphan_item
>>>>
>>>> made the whole path alloc/free go away.
>>
>> so I think there's no need for my patch; may as well just send the above to stable
>> and fix it that way, as long as 9c4f61f is deemed safe & correct, I think.
>
> Nice catch, thanks Eric. 9c4f61f looks fine for stable to me, but
> since he's already testing on stable, I talked Eric into giving it a
> pass through xfstests before I send it up.
>
> -chris
./check -g auto on 3.19-stable-ish seems fine-ish. Certainly no worse w/ the patch added :)
Failures: btrfs/010 btrfs/017 btrfs/078 generic/015 generic/039 generic/040 generic/041 generic/065 generic/066 generic/071 generic/204
Failed 11 of 202 tests
I'd say ship it!
-Eric
next prev parent reply other threads:[~2015-03-26 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 3:24 I think "btrfs: fix leak of path in btrfs_find_item" broke stable trees Eric Sandeen
2015-03-26 10:23 ` Filipe David Manana
2015-03-26 14:11 ` Eric Sandeen
2015-03-26 14:48 ` Chris Mason
2015-03-26 17:11 ` Eric Sandeen [this message]
2015-03-26 17:25 ` Filipe David Manana
2015-03-26 20:38 ` Eric Sandeen
2015-03-27 3:34 ` Eryu Guan
2015-03-27 21:49 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55143DD7.2020608@redhat.com \
--to=sandeen@redhat.com \
--cc=clm@fb.com \
--cc=fdmanana@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox