Re: [PATCH] btrfs: Fix superblock csum type check.

[Qu Wenruo <quwenruo@cn.fujitsu.com>]

-------- Original Message  --------
Subject: Re: [PATCH] btrfs: Fix superblock csum type check.
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Date: 2015年04月30日 01:23

> On Tue, Apr 28, 2015 at 09:06:03AM +0800, Qu Wenruo wrote:
>> Old csum type check is wrong and can't catch csum_type 1(not supported).
>>
>> Fix it to avoid hostile 0 division.
>>
>> Reported-by: Lukas Lueg <lukas.lueg@gmail.com>
>> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
>
> Reviewed-by: David Sterba <dsterba@suse.cz>
>
>> --- a/fs/btrfs/disk-io.c
>> +++ b/fs/btrfs/disk-io.c
>> @@ -428,7 +428,7 @@ static int btrfs_check_super_csum(char *raw_disk_sb)
>>
>>   	if (csum_type >= ARRAY_SIZE(btrfs_csum_sizes)) {
>>   		printk(KERN_ERR "BTRFS: unsupported checksum algorithm %u\n",
>> -				csum_type);
>> +		       csum_type);
>
> Please avoid unrelated changes.
Thanks for reviewing.

Do I need to send a newer version to discard this format change?

Thanks,
Qu
>
>>   		ret = 1;
>>   	}