From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:17306 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbbEFJRT (ORCPT ); Wed, 6 May 2015 05:17:19 -0400 Message-ID: <5549DB94.3050704@oracle.com> Date: Wed, 06 May 2015 17:15:00 +0800 From: Anand Jain MIME-Version: 1.0 To: xuw2015@gmail.com CC: dsterba@suse.cz, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 2/3] btrfs: support to find missing device by path References: <1430384845-9666-1-git-send-email-xuw2015@gmail.com> <1430384845-9666-2-git-send-email-xuw2015@gmail.com> <20150505153816.GJ5099@twin.jikos.cz> In-Reply-To: <20150505153816.GJ5099@twin.jikos.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 05/05/2015 11:38 PM, David Sterba wrote: > On Thu, Apr 30, 2015 at 05:07:24PM +0800, xuw2015@gmail.com wrote: >> From: George Wang >> >> First try to find the device matches specified device path, if nothing, then >> find the device by (devid, dev_uuid). This can fix the regression for >> replacing an offline device which path is held in btrfs_device. > > I vaguely remember similar patches sent by Anand, CCed. George, Critically we don't need this patch. right ? Anyway user of replace cli can use devid if device read fails. I think David is talking about: [PATCH] device delete by devid it was critical for device delete. since there was device delete by devid. I used device delete by devid instead of device path strcmp mainly because to maintain consistency between device replace and delete. the above patch set also provides code cleanups between device replace and delete codes. Thanks, Anand > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >