From: Anand Jain <Anand.Jain@oracle.com>
To: xuw2015@gmail.com
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] btrfs: support to find missing device by path
Date: Wed, 06 May 2015 17:22:41 +0800 [thread overview]
Message-ID: <5549DD61.8050502@oracle.com> (raw)
In-Reply-To: <5549DB94.3050704@oracle.com>
fix typo. (I have to blame thunderbird's bug which vanishes
some of the words as I scroll up and down in the 'write' window.).
On 05/06/2015 05:15 PM, Anand Jain wrote:
>
>
> On 05/05/2015 11:38 PM, David Sterba wrote:
>> On Thu, Apr 30, 2015 at 05:07:24PM +0800, xuw2015@gmail.com wrote:
>>> From: George Wang <xuw2015@gmail.com>
>>>
>>> First try to find the device matches specified device path, if
>>> nothing, then
>>> find the device by (devid, dev_uuid). This can fix the regression for
>>> replacing an offline device which path is held in btrfs_device.
>>
>> I vaguely remember similar patches sent by Anand, CCed.
>
> George,
>
> Critically we don't need this patch. right ?
> Anyway user of replace cli can use devid if device read fails.
>
> I think David is talking about:
> [PATCH] device delete by devid
>
> it was critical for device delete. since there wasn't device
> delete by devid. I used device delete by devid instead of
> device path strcmp mainly because to maintain consistency
> between device replace and delete.
> the above patch set also provides code cleanups between
> device replace and delete codes.
>
> Thanks, Anand
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-06 9:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 9:07 [PATCH 1/3] btrfs: introduce BTRFS_BLOCK_SIZE to replace number 4096 xuw2015
2015-04-30 9:07 ` [PATCH 2/3] btrfs: support to find missing device by path xuw2015
2015-05-05 15:38 ` David Sterba
2015-05-06 9:15 ` Anand Jain
2015-05-06 9:22 ` Anand Jain [this message]
2015-05-07 2:51 ` George Wang
2015-05-07 3:17 ` Anand Jain
2015-05-07 3:47 ` George Wang
2015-04-30 9:07 ` [PATCH 3/3] btrfs: do not allow device path updated by the stale one xuw2015
2015-05-05 15:34 ` [PATCH 1/3] btrfs: introduce BTRFS_BLOCK_SIZE to replace number 4096 David Sterba
2015-05-11 6:01 ` George Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5549DD61.8050502@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=xuw2015@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox