From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, Qu Wenruo <quwenruo@cn.fujitsu.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/8] Introduce offline fsid/chunk tree uuid change for btrfstune.
Date: Fri, 15 May 2015 23:42:57 +0800 [thread overview]
Message-ID: <55561401.8020904@oracle.com> (raw)
In-Reply-To: <20150513134329.GJ23255@suse.cz>
On 05/13/2015 09:43 PM, David Sterba wrote:
> On Tue, May 12, 2015 at 12:00:28PM +0800, Anand Jain wrote:
>> I strongly recommend this feature to be part of btrfstune as
>> of now, as originally planned by Qu. When its time to move
>> to btrfs cli we could. If we do it wrongly now it would stay
>> there forever.
>
> I agree with that now. The code to change the uuid is straightforward,
> we'd got stuck on getting the interface right. At the moment it's more
> likely to get it wrong because the properties are not finalized. A
> standalone tool for the uuid change is IMO not the right way either,
> btrfstune is usually packaged already.
How about placing the new sub-cli like below, until it finds its
final home.
btrfs unstable <sub-cli>
or
btrfs experimental <sub-cli>
thanks, Anand
> I'll go through the patches and take the core changes + the btrfstune
> interface from v1.
>
> Thank you both for the feedback.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-05-15 15:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 6:16 [PATCH 0/8] Introduce offline fsid/chunk tree uuid change for btrfstune Qu Wenruo
2015-05-05 6:16 ` [PATCH 1/8] btrfs-progs: Allow open_ctree to ignore fsid mismatch Qu Wenruo
2015-05-05 6:16 ` [PATCH 2/8] btrfs-progs: Export write_tree_block() Qu Wenruo
2015-05-05 6:16 ` [PATCH 3/8] btrfs-progs: Introduce change_header_uuid() function Qu Wenruo
2015-05-05 6:16 ` [PATCH 4/8] btrfs-progs: Introduce change_extents_uuid() function Qu Wenruo
2015-05-05 6:16 ` [PATCH 5/8] btrfs-progs: Introduce function change_device_uuid() Qu Wenruo
2015-05-05 6:16 ` [PATCH 6/8] btrfs-progs: Introduce change_devices_uuid() function Qu Wenruo
2015-05-05 6:16 ` [PATCH 7/8] btrfs-progs: Introduce change_uuid() function Qu Wenruo
2015-05-05 6:16 ` [PATCH 8/8] btrfs-progs: btrfstune: Introduce new "-u" and "-U" options Qu Wenruo
2015-05-05 15:20 ` [PATCH 0/8] Introduce offline fsid/chunk tree uuid change for btrfstune David Sterba
2015-05-06 0:49 ` Qu Wenruo
2015-05-06 15:43 ` David Sterba
2015-05-08 8:57 ` Qu Wenruo
2015-05-11 16:24 ` David Sterba
2015-05-12 2:09 ` Qu Wenruo
2015-05-12 4:00 ` Anand Jain
2015-05-13 0:54 ` Qu Wenruo
2015-05-13 13:43 ` David Sterba
2015-05-15 15:42 ` Anand Jain [this message]
2015-05-21 16:30 ` David Sterba
2015-05-22 15:20 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55561401.8020904@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).