From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org, dsterba@suse.com,
josef@toxicpanda.com,
syzbot+4cfe71a4da060be47502@syzkaller.appspotmail.com
Subject: Re: [PATCH RESEND v2] btrfs: fix devid 0 without a replace item by failing the mount
Date: Wed, 4 Nov 2020 08:55:38 +0800 [thread overview]
Message-ID: <556d196c-24df-b6f2-8a7b-3569f1421e17@oracle.com> (raw)
In-Reply-To: <20201103183618.GA6756@twin.jikos.cz>
>> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>> index 1b2742da5d4a..bb6f067f2fb9 100644
>> --- a/fs/btrfs/volumes.c
>> +++ b/fs/btrfs/volumes.c
>> @@ -1056,22 +1056,13 @@ static void __btrfs_free_extra_devids(struct btrfs_fs_devices *fs_devices,
>> continue;
>> }
>>
>> - if (device->devid == BTRFS_DEV_REPLACE_DEVID) {
>> - /*
>> - * In the first step, keep the device which has
>> - * the correct fsid and the devid that is used
>> - * for the dev_replace procedure.
>> - * In the second step, the dev_replace state is
>> - * read from the device tree and it is known
>> - * whether the procedure is really active or
>> - * not, which means whether this device is
>> - * used or whether it should be removed.
>> - */
>> - if (step == 0 || test_bit(BTRFS_DEV_STATE_REPLACE_TGT,
>
> This removes the use of step parameter so it can be removed from the
> call chain too (separate patch).
Will see to it.
> Patch added to misc-next, thanks.
Thanks.
prev parent reply other threads:[~2020-11-04 0:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 22:53 [PATCH 0/1] handle attacking device with devid=0 Anand Jain
2020-10-29 22:53 ` [PATCH RESEND v2] btrfs: fix devid 0 without a replace item by failing the mount Anand Jain
2020-11-03 18:36 ` David Sterba
2020-11-04 0:55 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556d196c-24df-b6f2-8a7b-3569f1421e17@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=syzbot+4cfe71a4da060be47502@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).