From: Goffredo Baroncelli <kreijack@inwind.it>
To: dsterba@suse.cz, Anand Jain <anand.jain@oracle.com>,
Omar Sandoval <osandov@fb.com>,
linux-btrfs@vger.kernel.org, Chris Mason <clm@fb.com>
Subject: Re: [PATCH 0/2] btrfs device remove alias
Date: Sat, 27 Jun 2015 13:38:37 +0200 [thread overview]
Message-ID: <558E8B3D.5070906@inwind.it> (raw)
In-Reply-To: <20150626133323.GS726@twin.jikos.cz>
On 2015-06-26 15:33, David Sterba wrote:
> On Fri, Jun 26, 2015 at 09:10:56AM +0800, Anand Jain wrote:
>> while on this. its also good idea to create alias for
>>
>> btrfs replace start -> btrfs device replace.
>
> This was asked for back then, and briefly discussed on irc (11/2012).
> The preference was not to do too much typing, although the command
> hierarchy would become less structured and can cause some trouble when
> looking for docs.
>
> I'm slightly worried about adding more aliases as it can cause confusion
> when writing documentaiton and recommending how to do things. But I
> understand the motivations to make the interface more consistent or
> convenient to use.
>
> In this case it's moving replace to the expected place. I'm not against
> it but more feedback would help.
I agree that btrfs device replace makes sense. The point is what about btrfs
replace status and cancel.
We could add these subcommand to device too, also because it makes sense to
extend these to support the remove/delete command. I am not suggesting to
do that now, but our decision has to take in account also these (possible ?)
further alias.
Goffredo
--
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
prev parent reply other threads:[~2015-06-27 11:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 16:09 [PATCH 0/2] btrfs device remove alias Omar Sandoval
2015-06-24 16:09 ` [PATCH 1/2] btrfs-progs: replace struct cmd_group->hidden with flags Omar Sandoval
2015-06-26 14:34 ` David Sterba
2015-06-24 16:09 ` [PATCH 2/2] btrfs-progs: alias btrfs device delete to btrfs device remove Omar Sandoval
2015-06-26 14:46 ` David Sterba
2015-06-25 4:06 ` [PATCH 0/2] btrfs device remove alias Duncan
2015-06-25 13:41 ` David Sterba
2015-06-25 13:45 ` Chris Mason
2015-06-26 1:10 ` Anand Jain
2015-06-26 4:21 ` Duncan
2015-06-26 13:33 ` David Sterba
2015-06-27 11:38 ` Goffredo Baroncelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558E8B3D.5070906@inwind.it \
--to=kreijack@inwind.it \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox