From: Josef Bacik <jbacik@fb.com>
To: Marc MERLIN <marc@merlins.org>
Cc: <dsterba@suse.com>, <clm@fb.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: kernel BUG at fs/btrfs/extent-tree.c:8113! (4.1.3 kernel)
Date: Wed, 12 Aug 2015 12:18:45 -0400 [thread overview]
Message-ID: <55CB71E5.1070302@fb.com> (raw)
In-Reply-To: <20150812160936.GK29259@merlins.org>
On 08/12/2015 12:09 PM, Marc MERLIN wrote:
> On Wed, Aug 12, 2015 at 11:15:39AM -0400, Josef Bacik wrote:
>> On 08/12/2015 10:47 AM, Marc MERLIN wrote:
>>> On Tue, Aug 11, 2015 at 11:40:45AM -0400, Josef Bacik wrote:
>>>> From a48cf7a9ae44a17d927df5542c8b0be287aee9ed Mon Sep 17 00:00:00 2001
>>>> From: Josef Bacik <jbacik@fb.com>
>>>> Date: Tue, 11 Aug 2015 11:39:37 -0400
>>>> Subject: [PATCH] Btrfs: kill BUG_ON() in btrfs_lookup_extent_info()
>>>>
>>>> Replace it with an ASSERT(0) for the developers and an error for not the
>>>> developers.
>>>
>>> Thanks. We knocked one down and now another BUG has been triggered :)
>>>
>>> if (unlikely(wc->refs[level - 1] == 0)) {
>>> btrfs_err(root->fs_info, "Missing references.");
>>> BUG();
>>> }
>>>
>>
>> This is why you got your own branch, it's never just one. Here's
>> the next bit
>
> Yes, I figured there might be a few more :)
> Thanks for this patch, it definitely made things better:
>
> [ 165.656408] BTRFS info (device dm-0): disk space caching is enabled
> [ 205.528199] BTRFS error (device dm-0): Missing references.
> [ 205.528216] BTRFS: error (device dm-0) in btrfs_drop_snapshot:8652: errno=-5 IO failure
> [ 205.528225] BTRFS info (device dm-0): forced readonly
>
> That's perfect, thanks much for that.
>
> Now, back to check --repair, does it make sense to fix it too so that it doesn't crash either?
>
> myth:~# btrfs check --repair /dev/mapper/crypt_sdd1
> enabling repair mode
> Checking filesystem on /dev/mapper/crypt_sdd1
> UUID: 024ba4d0-dacb-438d-9f1b-eeb34083fe49
> checking extents
> cmds-check.c:4486: add_data_backref: Assertion `back->bytes != max_size` failed.
> btrfs[0x8066a73]
> btrfs[0x8066aa4]
> btrfs[0x8067991]
> btrfs[0x806b4ab]
> btrfs[0x806b9a3]
> btrfs[0x806c5b2]
> btrfs(cmd_check+0x1088)[0x806eddf]
> btrfs(main+0x153)[0x80557c6]
> /lib/i386-linux-gnu/libc.so.6(__libc_start_main+0xf3)[0xb75784d3]
> btrfs[0x80557ec]
>
Going to need more info to figure this one out
From d77cd13f94fae6d995f753f3de3728c4ef4f8e75 Mon Sep 17 00:00:00 2001
From: Josef Bacik <jbacik@fb.com>
Date: Wed, 12 Aug 2015 12:18:01 -0400
Subject: [PATCH] some debugging
---
cmds-check.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/cmds-check.c b/cmds-check.c
index dd2fce3..8f668d7 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -4524,6 +4524,8 @@ static int add_data_backref(struct cache_tree
*extent_cache, u64 bytenr,
if (found_ref) {
BUG_ON(num_refs != 1);
if (back->node.found_ref)
+ if (back->bytes != max_size)
+ fprintf(stderr, "wtf, parent %llu\n", (unsigned long long)parent);
BUG_ON(back->bytes != max_size);
back->node.found_ref = 1;
back->found_ref += 1;
--
2.1.0
next prev parent reply other threads:[~2015-08-12 16:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 21:21 btrfs check --repair crash, and btrfs-cleaner crash Marc MERLIN
2015-07-10 13:43 ` Btrfs progs release 4.1.1 David Sterba
2015-07-12 1:02 ` Marc MERLIN
2015-07-23 11:55 ` David Sterba
2015-07-24 16:24 ` Marc MERLIN
2015-08-03 3:51 ` kernel BUG at fs/btrfs/extent-tree.c:8113! (4.1.3 kernel) Marc MERLIN
2015-08-11 5:07 ` Marc MERLIN
2015-08-11 15:40 ` Josef Bacik
2015-08-12 14:47 ` Marc MERLIN
2015-08-12 15:15 ` Josef Bacik
2015-08-12 16:09 ` Marc MERLIN
2015-08-12 16:18 ` Josef Bacik [this message]
2015-08-12 17:19 ` Marc MERLIN
2015-08-17 2:01 ` Qu Wenruo
2015-08-17 14:49 ` Marc MERLIN
2015-08-22 14:37 ` Marc MERLIN
2015-08-24 1:10 ` Qu Wenruo
2015-08-24 4:28 ` Marc MERLIN
2015-08-24 5:11 ` Qu Wenruo
2015-08-24 14:10 ` Marc MERLIN
2015-08-25 0:26 ` Qu Wenruo
2015-08-25 2:51 ` Qu Wenruo
2015-08-25 5:28 ` Marc MERLIN
2015-08-25 6:00 ` Qu Wenruo
2015-08-25 6:50 ` Marc MERLIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB71E5.1070302@fb.com \
--to=jbacik@fb.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marc@merlins.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).