linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <dsterba@suse.cz>, Zhao Lei <zhaolei@cn.fujitsu.com>,
	<linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: scrub: set error stats when tree block spanning stripes
Date: Fri, 4 Sep 2015 11:21:05 +0800	[thread overview]
Message-ID: <55E90E21.9020004@cn.fujitsu.com> (raw)
In-Reply-To: <20150903131719.GR11834@twin.jikos.cz>

Hi, David and Zhao,

David Sterba wrote on 2015/09/03 15:17 +0200:
> On Thu, Aug 27, 2015 at 09:44:05AM +0800, Zhao Lei wrote:
> [...]
>
> Thanks for the links and summary!
>
>> But it is still uncorrectable because neither kernel nor btrfsck can fix
>> it(only can report).
>
> I'm curious if it' is possible to write code that would fix the problem,
> eg. te relocate or shift the blocks. The 'btrfs rescue' command group is
> meant for this type of targeted fixes, unless it's easy to integrate it
> to the check & repair itself.

I'm happy and willing to add the relocating ability for btrfs-progs.
As that will provide a lot of flexibility, while the code should be 
quite easy if I do it in a NOCOW method.
(Find a extent, copy it to other place, follow backref and modify)

The only concern is, does it mean that we need to implement all the 
features of btrfs kernel in user space tool?
And will it make the codes duplicated between kernel and progs?

Thanks,
Qu

>
>> In short, it is caused by old version of btrfs-convert, and already fixed,
>> and this patch is used to make scrub report it in output.
>
> I assume there are people affected by this problem so it would be good
> to have a repair tool.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2015-09-04  3:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25 13:45 [PATCH] btrfs: scrub: set error stats when tree block spanning stripes Zhao Lei
2015-08-26 17:19 ` David Sterba
2015-08-27  1:44   ` Zhao Lei
2015-09-03 13:17     ` David Sterba
2015-09-04  3:21       ` Qu Wenruo [this message]
2015-09-07 12:37         ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E90E21.9020004@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=zhaolei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).