From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>
Cc: Qu Wenru <wqu@suse.com>, Damien Le Moal <dlemoal@kernel.org>,
Naohiro Aota <naohiro.aota@wdc.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] btrfs: RAID stripe tree updates
Date: Wed, 4 Oct 2023 18:55:45 +1030 [thread overview]
Message-ID: <55caa26c-3448-492c-b139-32c756556b34@gmx.com> (raw)
In-Reply-To: <20231004-rst-updates-v3-0-7729c4474ade@wdc.com>
On 2023/10/4 18:26, Johannes Thumshirn wrote:
> This batch of RST updates contains the on-disk format changes Qu
> suggested. It drastically simplifies the write and path, especially for
> RAID10.
>
> Instead of recording all strides of a striped RAID into one stripe tree
> entry, we create multiple entries per stride. This allows us to remove the
> length in the stride as we can use the length from the key. Using this
> method RAID10 becomes RAID1 and RAID0 becomes single from the point of
> view of the stripe tree.
Great the idea can simplify the code.
So I'm very glad I can provide some help on RST.
Although one concern is about the compatibility, but I guess since rst
is still covered under experimental flags for progs, we can more or less
ignore the compatibility for now?
The other concern is, how would those patches be merged, would David
just fold them, and we can check the misc-next, or there would be
another branch for us to view the code?
Thanks,
Qu
>
> ---
> - Link to first batch: https://lore.kernel.org/r/20230918-rst-updates-v1-0-17686dc06859@wdc.com
> - Link to second batch: https://lore.kernel.org/r/20230920-rst-updates-v2-0-b4dc154a648f@wdc.com
>
> ---
> Johannes Thumshirn (4):
> btrfs: change RST write
> btrfs: remove stride length check on read
> btrfs: remove raid stride length in tree printer
> btrfs: remove stride length from on-disk format
>
> fs/btrfs/accessors.h | 2 -
> fs/btrfs/print-tree.c | 5 +-
> fs/btrfs/raid-stripe-tree.c | 173 ++--------------------------------------
> include/uapi/linux/btrfs_tree.h | 2 -
> 4 files changed, 7 insertions(+), 175 deletions(-)
> ---
> base-commit: 8d3aed36ee6cac09c7bd6bee6ad67dc2a35615af
> change-id: 20230915-rst-updates-8c55784ca4ef
>
> Best regards,
next prev parent reply other threads:[~2023-10-04 8:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 7:56 [PATCH v3 0/4] btrfs: RAID stripe tree updates Johannes Thumshirn
2023-10-04 7:56 ` [PATCH v3 1/4] btrfs: change RST write Johannes Thumshirn
2023-10-04 12:43 ` Johannes Thumshirn
2023-10-04 7:56 ` [PATCH v3 2/4] btrfs: remove stride length check on read Johannes Thumshirn
2023-10-04 12:43 ` Johannes Thumshirn
2023-10-04 7:56 ` [PATCH v3 3/4] btrfs: remove raid stride length in tree printer Johannes Thumshirn
2023-10-04 12:44 ` Johannes Thumshirn
2023-10-04 7:56 ` [PATCH v3 4/4] btrfs: remove stride length from on-disk format Johannes Thumshirn
2023-10-04 12:45 ` Johannes Thumshirn
2023-10-04 8:25 ` Qu Wenruo [this message]
2023-10-04 8:36 ` [PATCH v3 0/4] btrfs: RAID stripe tree updates Johannes Thumshirn
2023-10-04 13:14 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55caa26c-3448-492c-b139-32c756556b34@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=clm@fb.com \
--cc=dlemoal@kernel.org \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).