From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net ([212.227.15.18]:54116 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934041AbbI2Kqe (ORCPT ); Tue, 29 Sep 2015 06:46:34 -0400 Subject: Re: [PATCH v2] fstests: generic: Check if a bull fallocate will change extent number To: Eryu Guan References: <1443519264-19184-1-git-send-email-quwenruo@cn.fujitsu.com> <20150929095549.GH30949@dhcp-13-216.nay.redhat.com> <560A64EB.5070401@gmx.com> <20150929103338.GI30949@dhcp-13-216.nay.redhat.com> Cc: Qu Wenruo , linux-btrfs@vger.kernel.org, fstests@vger.kernel.org From: Qu Wenruo Message-ID: <560A6BFF.2020508@gmx.com> Date: Tue, 29 Sep 2015 18:46:23 +0800 MIME-Version: 1.0 In-Reply-To: <20150929103338.GI30949@dhcp-13-216.nay.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: 在 2015年09月29日 18:33, Eryu Guan 写道: > On Tue, Sep 29, 2015 at 06:16:11PM +0800, Qu Wenruo wrote: >> > >>>> + >>>> +if [ "x$orig_extent_nr" != "x$new_extent_nr" ]; then >>>> + echo "number of extents mis-match after bull fallocate" >>> >>> print out the $orig_extent_nr and $new_extent_nr in this failure case? I >>> think it's useful to see the difference just from the output diff, don't >>> have to check the full file. >> >> The problem is, we can't ensure orig/new_extent_nr always be a constant >> value(1 for btrfs case). > > Sorry, I might be unclear, I mean print the extent number in the error > path, e.g. > > echo "number of extents mis-match after null fallocate" > echo "old: $orig_extent_nr, new: $new_extent_nr" > > not matching the number with golden output. > > Thanks, > Eryu That sounds pretty nice. Will change it in next version. Thanks, Qu > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >