linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>,
	linux-btrfs@vger.kernel.org, Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: dsterba@suse.cz
Subject: Re: [PATCH 1/1] Btrfs: consolidate btrfs_error() to btrfs_std_error()
Date: Fri, 02 Oct 2015 17:38:30 +0800	[thread overview]
Message-ID: <560E5096.7050903@oracle.com> (raw)
In-Reply-To: <560E40E5.1000602@gmx.com>



> It only needs to log an error, no need to mark FS_ERROR bit.
> As it may just be an invalid parameter.

  This ans-ed my question. Then there are two bugs. one which David
  pointed out. two In original code (before this patch), it should
  have been calling btrfs_err() instead of btrfs_error().

Thanks, Anand

  reply	other threads:[~2015-10-02  9:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25  6:43 [PATCH 1/1] Btrfs: consolidate btrfs_error() to btrfs_std_error() Anand Jain
2015-09-25 10:31 ` David Sterba
2015-10-02  7:41   ` Anand Jain
2015-10-02  8:31     ` Qu Wenruo
2015-10-02  9:38       ` Anand Jain [this message]
2015-10-02 10:46   ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560E5096.7050903@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=quwenruo@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).