Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: David Sterba <dsterba@suse.com>, btrfs <linux-btrfs@vger.kernel.org>
Subject: [devel branch]Btrfs-convert assert at volumes.c:1846
Date: Mon, 19 Oct 2015 17:30:16 +0800	[thread overview]
Message-ID: <5624B828.80405@cn.fujitsu.com> (raw)

Hi David and all,

Recently I'm reworking the btrfs-convert chunk allocater to make it able 
to separate data and meta chunk.

But when I was testing, I found that, your devel branch, with the 
following commit just fails to convert an empty ext4 filesystem:

commit 0002085c53a5ac9ad1c538bfc3e39c80891c4a1a
Author: Zhao Lei <zhaolei@cn.fujitsu.com>
Date:   Mon Oct 12 21:23:04 2015 +0800

     btrfs-progs: fragments: use btrfs_open_dir for btrfs-fragments command

     We can use btrfs_open_dir() to check whether target dir is
     in btrfs's mount point before open, instead of checking it in
     deeper code, and return fuzzy error message.

     Before patch:
       ./btrfs-fragments -o 123 /mnt/tmp1
       ERROR: can't perform the search

     After patch:
       # ./btrfs-fragments -o 123 /mnt/tmp1
       ERROR: not a btrfs filesystem: /mnt/tmp1

     Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
     Signed-off-by: David Sterba <dsterba@suse.com>


The error output is:
create btrfs filesystem:
	blocksize: 4096
	nodesize:  16384
	features:  extref, skinny-metadata (default)
volumes.c:1846: btrfs_read_sys_array: Assertion failed.
./btrfs-convert(btrfs_read_sys_array+0x1b8)[0x42422c]
./btrfs-convert(btrfs_setup_chunk_tree_and_device_map+0x41)[0x41176b]
./btrfs-convert[0x411a22]
./btrfs-convert(open_ctree_fd+0x10)[0x411b59]
./btrfs-convert(main+0x1814)[0x4382d7]
/usr/lib/libc.so.6(__libc_start_main+0xf0)[0x7f5571479610]
./btrfs-convert(_start+0x29)[0x407979]

Any ideas?
I hope it won't block me too long to test my rework.

Thanks,
Qu

             reply	other threads:[~2015-10-19  9:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19  9:30 Qu Wenruo [this message]
2015-10-19 11:21 ` [devel branch]Btrfs-convert assert at volumes.c:1846 David Sterba
2015-10-19 12:38   ` Qu Wenruo
2015-10-20  2:33     ` Qu Wenruo
2015-10-21 11:52       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5624B828.80405@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox