diff --git a/block/blk-core.c b/block/blk-core.c index 5131993b23a1..4237facaafa5 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -3192,7 +3192,7 @@ static void queue_unplugged(struct request_queue *q, unsigned int depth, spin_unlock(q->queue_lock); } -static void flush_plug_callbacks(struct blk_plug *plug, bool from_schedule) +void flush_plug_callbacks(struct blk_plug *plug, bool from_schedule) { LIST_HEAD(callbacks); diff --git a/block/blk-mq.c b/block/blk-mq.c index 3ae09de62f19..e92f52462222 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1065,7 +1065,8 @@ static int plug_ctx_cmp(void *priv, struct list_head *a, struct list_head *b) blk_rq_pos(rqa) < blk_rq_pos(rqb))); } -void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule) +static void __blk_mq_flush_plug_list(struct blk_plug *plug, bool from_sched, + bool skip_last) { struct blk_mq_ctx *this_ctx; struct request_queue *this_q; @@ -1084,13 +1085,15 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule) while (!list_empty(&list)) { rq = list_entry_rq(list.next); + if (skip_last && list_is_last(&rq->queuelist, &list)) + break; list_del_init(&rq->queuelist); BUG_ON(!rq->q); if (rq->mq_ctx != this_ctx) { if (this_ctx) { blk_mq_insert_requests(this_q, this_ctx, &ctx_list, depth, - from_schedule); + from_sched); } this_ctx = rq->mq_ctx; @@ -1108,8 +1111,14 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule) */ if (this_ctx) { blk_mq_insert_requests(this_q, this_ctx, &ctx_list, depth, - from_schedule); + from_sched); } + +} + +void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule) +{ + __blk_mq_flush_plug_list(plug, from_schedule, false); } static void blk_mq_bio_to_request(struct request *rq, struct bio *bio) @@ -1291,15 +1300,16 @@ static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio) blk_mq_bio_to_request(rq, bio); /* - * we do limited pluging. If bio can be merged, do merge. + * We do limited pluging. If the bio can be merged, do that. * Otherwise the existing request in the plug list will be * issued. So the plug list will have one request at most */ if (plug) { /* * The plug list might get flushed before this. If that - * happens, same_queue_rq is invalid and plug list is empty - **/ + * happens, same_queue_rq is invalid and plug list is + * empty + */ if (same_queue_rq && !list_empty(&plug->mq_list)) { old_rq = same_queue_rq; list_del_init(&old_rq->queuelist); @@ -1380,12 +1390,24 @@ static blk_qc_t blk_sq_make_request(struct request_queue *q, struct bio *bio) blk_mq_bio_to_request(rq, bio); if (!request_count) trace_block_plug(q); - else if (request_count >= BLK_MAX_REQUEST_COUNT) { - blk_flush_plug_list(plug, false); - trace_block_plug(q); - } + list_add_tail(&rq->queuelist, &plug->mq_list); blk_mq_put_ctx(data.ctx); + + /* + * We unplug manually here, flushing both callbacks and + * potentially queued up IO - except the one we just added. + * That one did not merge with existing requests, so could + * be a candidate for new incoming merges. Tell + * __blk_mq_flush_plug_list() to skip issuing the last + * request in the list, which is the 'rq' from above. + */ + if (request_count >= BLK_MAX_REQUEST_COUNT) { + flush_plug_callbacks(plug, false); + __blk_mq_flush_plug_list(plug, false, true); + trace_block_plug(q); + } + return cookie; } diff --git a/block/blk.h b/block/blk.h index c43926d3d74d..3e0ae1562b85 100644 --- a/block/blk.h +++ b/block/blk.h @@ -107,6 +107,7 @@ bool blk_attempt_plug_merge(struct request_queue *q, struct bio *bio, unsigned int *request_count, struct request **same_queue_rq); unsigned int blk_plug_queued_count(struct request_queue *q); +void flush_plug_callbacks(struct blk_plug *plug, bool from_schedule); void blk_account_io_start(struct request *req, bool new_io); void blk_account_io_completion(struct request *req, unsigned int bytes);