From: Anand Jain <anand.jain@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Cc: josef@toxicpanda.com, dsterba@suse.com, l@damenly.su
Subject: Re: [External] : Re: [PATCH v4 2/4] btrfs: redeclare btrfs_stale_devices arg1 to dev_t
Date: Tue, 11 Jan 2022 12:51:08 +0800 [thread overview]
Message-ID: <5656e466-7950-2dd0-11f0-2dadcc191f7c@oracle.com> (raw)
In-Reply-To: <df5e06aa-5ed4-0df2-9210-ea8d19069cba@suse.com>
>> @@ -604,14 +599,14 @@ static int btrfs_free_stale_devices(const char *path,
>> &fs_devices->devices, dev_list) {
>> if (skip_device && skip_device == device)
>> continue;
>> - if (path && !device->name)
>> + if (devt && !device->name)
>
> This check is now rendered obsolete since ->name is used iff we have
> passed a patch to match against it, but since your series removes the
> path altogether having device->name becomes obsolete, hence it can be
> removed.
We have it to check for the missing device. Device->name == '\0' is one
of the ways coded to identify a missing device. It helps to fail early
instead of failing inside device_matched() at lookup_bdev().
Thanks, Anand
next prev parent reply other threads:[~2022-01-11 4:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 13:23 [PATCH v4 0/4] btrfs: match device by dev_t Anand Jain
2022-01-10 13:23 ` [PATCH v4 1/4] btrfs: harden identification of the stale device Anand Jain
2022-01-10 14:41 ` Nikolay Borisov
2022-01-11 4:50 ` [External] : " Anand Jain
2022-01-10 13:23 ` [PATCH v4 2/4] btrfs: redeclare btrfs_stale_devices arg1 to dev_t Anand Jain
2022-01-10 15:20 ` Nikolay Borisov
2022-01-11 4:51 ` Anand Jain [this message]
2022-01-11 8:30 ` [External] : " Nikolay Borisov
2022-01-11 12:36 ` Anand Jain
2022-01-11 12:49 ` Nikolay Borisov
2022-01-11 13:58 ` Nikolay Borisov
2022-01-12 4:13 ` Anand Jain
2022-01-10 13:23 ` [PATCH v4 3/4] btrfs: add device major-minor info in the struct btrfs_device Anand Jain
2022-01-10 20:13 ` Goffredo Baroncelli
2022-01-11 5:27 ` Anand Jain
2022-01-11 17:18 ` Goffredo Baroncelli
2022-01-12 3:17 ` Anand Jain
2022-01-13 6:09 ` Goffredo Baroncelli
2022-01-10 13:23 ` [PATCH v4 4/4] btrfs: use dev_t to match device in device_matched Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5656e466-7950-2dd0-11f0-2dadcc191f7c@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=l@damenly.su \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox