Re: potential btrfs-progs clean up

[Qu Wenruo <quwenruo@cn.fujitsu.com>]

Anand Jain wrote on 2015/11/30 13:44 +0800:
>
>
> (this is a different topic, updated the subject)
>
>> Totally agree with this point. Too many non-sense in btrfs-progs codes
>> copied from kernel, and due to lack of update, it's very buggy now.
>> Just check volume.c for allocating data chunk.
>
>    Which functions in volume.c in particular ?

btrfs_alloc_chunk().

1) Fixed SINGLE DATA chunk size
The point is very easy, for SINGLE and DATA chunk, its size is always 
fixed to 8M. (below minimal data chunk size already)
Normally it's OK, but not the normal 10% of filesystem.

The bug is hidden by the complicated PROFILE if sentences.

2) Not that clear chunk size limitation.
And the logical of btrfs_alloc_chunk() is not that clear to for the 
minimal *stripe* size(which is physical) and minimal *chunk* size(which 
is logical).

Not a real problem yet.

3) Duplicated chunk allocation functions
Btrfs_alloc_chunk(), btrfs_alloc_data_chunk().

But don't cleanup the latter one yet, as btrfs-convert rework still 
needs it to avoid some chunk allocation check.

Thanks,
Qu


>
> Thanks, Anand
>
>