Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: Roman Mamedov <rm@romanrm.net>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2] btrfs: Introduce new mount option to disable tree log replay
Date: Tue, 8 Dec 2015 14:50:42 +0800	[thread overview]
Message-ID: <56667DC2.6080507@cn.fujitsu.com> (raw)
In-Reply-To: <20151208113152.5f8edeaf@natsu>



Roman Mamedov wrote on 2015/12/08 11:31 +0500:
> On Tue,  8 Dec 2015 14:10:33 +0800
> Qu Wenruo <quwenruo@cn.fujitsu.com> wrote:
>
>> Introduce a new mount option "nologreplay" to co-operate with "ro" mount
>> option to get real readonly mount, like "norecovery" in ext* and xfs.
>
> Maybe name it "norecovery" too, for simplicity and consistency?

That's also our first idea.
But the sad fact is, btrfs already has a mount option called "recovery".

So "norecovery" here will just be considered as a mount option to 
disable "recovery", and that will make things more confusing.

And finally we choose the name "nologreplay".

Thanks,
Qu

>
> The actual effect of "norecovery" in ext* and xfs is to also disable log
> replay, but that's an under-the-hood detail not relevant to the user.
>
> ---
> Mount options for ext3
>
>         norecovery/noload
>                Don't load the journal on mounting.  Note that if the filesystem
>                was not unmounted cleanly, skipping the journal replay will lead
>                to  the  filesystem  containing inconsistencies that can lead to
>                any number of problems.
> ---
> Mount options for xfs
>
>         norecovery
>                The filesystem will be mounted without running log recovery.  If
>                the filesystem was not cleanly unmounted, it  is  likely  to  be
>                inconsistent  when  mounted  in  norecovery mode.  Some files or
>                directories may not be accessible because of this.   Filesystems
>                mounted  norecovery  must be mounted read-only or the mount will
>                fail.
> ---
>



  reply	other threads:[~2015-12-08  6:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08  6:10 [PATCH v2] btrfs: Introduce new mount option to disable tree log replay Qu Wenruo
2015-12-08  6:31 ` Roman Mamedov
2015-12-08  6:50   ` Qu Wenruo [this message]
2015-12-08 10:06 ` Chandan Rajendra
2015-12-10  1:24   ` Qu Wenruo
2015-12-08 16:24 ` Austin S Hemmelgarn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56667DC2.6080507@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=rm@romanrm.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox