Re: [PATCH v2 1/2] btrfs: Enhance super validation check

[Qu Wenruo <quwenruo@cn.fujitsu.com>]

David Sterba wrote on 2015/12/14 17:24 +0100:
> On Tue, Dec 08, 2015 at 03:35:57PM +0800, Qu Wenruo wrote:
>> @@ -4005,31 +3989,47 @@ static int btrfs_check_super_valid(struct btrfs_fs_info *fs_info,
>>   	}
>>
>>   	/*
>> -	 * The common minimum, we don't know if we can trust the nodesize/sectorsize
>> -	 * items yet, they'll be verified later. Issue just a warning.
>> +	 * Check sectorsize and nodesize first, some other check will need it.
>> +	 * XXX: Just do a favor for later subpage size check. Check all
>
> Same as in v1: Please do not add new XXX or TODO markers to the sources.
> The comment would be fine with just:
>
> 	 "Check all possible sectorsizes (4K, 8K, 16K, 32K, 64K) here."
>
> With that fixed,
>
> Reviewed-by: David Sterba <dsterba@suse.com>
>
>
Oh, sorry, forgot to modify this, I'll update it soon.

Thanks,
Qu