linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Quigley <tsimonq2@ubuntu.com>
To: clm@fb.com, joe@perches.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80
Date: Sat, 20 Feb 2016 18:57:23 -0600	[thread overview]
Message-ID: <56C90B73.7030702@ubuntu.com> (raw)
In-Reply-To: <1456016178-4560-1-git-send-email-tsimonq2@ubuntu.com>

Better?

On 02/20/2016 06:56 PM, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833
>
> Adjusted to put &extref and &offset on a different line
>
> Signed-off-by: Simon Quigley <tsimonq2@ubuntu.com>
> ---
>   fs/btrfs/backref.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index f6dac40..956fffa 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
>   	unsigned long ptr;
>
>   	while (1) {
> -		ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
> -					    &offset);
> +		ret = btrfs_find_one_extref(fs_root, inum, offset, path,
> +							&extref, &offset);
>   		if (ret < 0)
>   			break;
>   		if (ret) {
>

  reply	other threads:[~2016-02-21  0:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20 18:17 [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters Simon Quigley
2016-02-21  0:02 ` Joe Perches
2016-02-21  0:56 ` [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 Simon Quigley
2016-02-21  0:57   ` Simon Quigley [this message]
2016-02-21  1:49     ` Joe Perches
2016-02-21  2:06 ` [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters Simon Quigley
2016-02-21  2:08   ` Simon Quigley
2016-02-22 11:57 ` David Sterba
2016-02-22 12:10   ` Simon Quigley
2016-02-22 12:33     ` David Sterba
2016-02-22 12:36       ` Simon Quigley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C90B73.7030702@ubuntu.com \
    --to=tsimonq2@ubuntu.com \
    --cc=clm@fb.com \
    --cc=joe@perches.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).