From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, clm@fb.com
Subject: Re: [PATCH 00/15] Device delete by id
Date: Fri, 11 Mar 2016 16:16:56 +0800 [thread overview]
Message-ID: <56E27EF8.1080408@oracle.com> (raw)
In-Reply-To: <20160225175905.GJ23746@twin.jikos.cz>
On 02/26/2016 01:59 AM, David Sterba wrote:
> On Mon, Feb 15, 2016 at 06:33:56PM +0100, David Sterba wrote:
>> this patchset extends the ioctl arugments to take an id so we can delete a
>> device by it. It reuses the existing structure btrfs_ioctl_vol_args_v2 and
>> extends it in na backward-compatible way so that we don't need to introduce
>> another one.
>>
>> The core patchset is from Anand, I did some cleanups as I went through the
>> series again and made some cleanups and minor naming tweaks to the interface.
>>
>> I'll add the branch to for-next and if everything goes fine I'll send a pull
>> request for 4.6 in a week.
>
> This patchset is causing crashes in my setup, based on linux-next tree
> with my for-next. I did a test round without it and it passes, so I'm
> removing it from 4.6 queue. We need more time to find and fix it.
(crash.. are you ref to the below ?)
BUG: unable to handle kernel NULL pointer dereference
scrub_setup_ctx.isra.19+0x1f6/0x260 [btrfs]
Current status: as of now there is nothing that tells me the
above crash was due to the set of patches in here, if there
are further data I will be happy to review, also this wasn't
reproducible.
Also:
Most of the xfstest btrfs/tests aren't designed to generate a
consistent result, it can be consistent with a sequence of tests,
but when this sequence of tests is altered, it may generate
different results.
As xfstest results also depends on the factors like state of
stale FSID on the devices and state of btrfs_device list with
in the kernel, which depends on the previous tests.
And looks like following changes can make it consistent.
Before each test/sub-test:
. wipefs -a of all scratch pool dev
. modprobe -r btrfs && modprobe btrfs
So that kernel will have a clean state of btrfs_device list.
Which means all the btrfs tests especially which are grouped
under replace should be updated with the above change, So that
we can ensure kernel and devices are in the same state each
time the test is run.
Any idea?
Thanks, Anand
prev parent reply other threads:[~2016-03-11 8:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 17:33 [PATCH 00/15] Device delete by id David Sterba
2016-02-15 17:33 ` [PATCH 01/15] btrfs: create a helper function to read the disk super David Sterba
2016-02-15 17:34 ` [PATCH 02/15] btrfs: create helper function __check_raid_min_devices() David Sterba
2016-02-15 17:34 ` [PATCH 03/15] btrfs: clean up and optimize __check_raid_min_device() David Sterba
2016-02-15 17:34 ` [PATCH 04/15] btrfs: create helper btrfs_find_device_by_user_input() David Sterba
2016-02-15 17:34 ` [PATCH 05/15] btrfs: make use of btrfs_find_device_by_user_input() David Sterba
2016-02-15 17:34 ` [PATCH 06/15] btrfs: enhance btrfs_find_device_by_user_input() to check device path David Sterba
2016-02-15 17:34 ` [PATCH 07/15] btrfs: make use of btrfs_scratch_superblocks() in btrfs_rm_device() David Sterba
2016-02-15 17:34 ` [PATCH 08/15] btrfs: introduce device delete by devid David Sterba
2016-02-15 17:34 ` [PATCH 09/15] btrfs: optimize check for stale device David Sterba
2016-02-15 17:34 ` [PATCH 10/15] btrfs: rename __check_raid_min_devices David Sterba
2016-02-16 9:07 ` Anand Jain
2016-02-15 17:34 ` [PATCH 11/15] btrfs: pass number of devices to btrfs_check_raid_min_devices David Sterba
2016-02-16 9:08 ` Anand Jain
2016-02-15 17:34 ` [PATCH 12/15] btrfs: indtroduce raid-type to error-code table, for minimum device constraint David Sterba
2016-02-16 9:09 ` Anand Jain
2016-02-15 17:34 ` [PATCH 13/15] btrfs: use existing device constraints table btrfs_raid_array David Sterba
2016-02-16 9:13 ` Anand Jain
2016-02-15 17:34 ` [PATCH 14/15] btrfs: rename btrfs_find_device_by_user_input David Sterba
2016-02-16 9:14 ` Anand Jain
2016-02-15 17:34 ` [PATCH 15/15] btrfs: rename flags for vol args v2 David Sterba
2016-02-16 9:18 ` Anand Jain
2016-02-16 9:43 ` David Sterba
2016-02-25 17:59 ` [PATCH 00/15] Device delete by id David Sterba
2016-03-11 8:16 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E27EF8.1080408@oracle.com \
--to=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).