From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <quwenruo@cn.fujitsu.com>,
NeilBrown <neilb@suse.com>,
linux-btrfs@vger.kernel.org, clm@fb.com,
Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
Subject: Re: [PATCH v7 01/20] btrfs: dedup: Introduce dedup framework and its header
Date: Sat, 12 Mar 2016 16:16:48 +0800 [thread overview]
Message-ID: <56E3D070.3020005@gmx.com> (raw)
In-Reply-To: <20160311114305.GQ18908@twin.jikos.cz>
On 03/11/2016 07:43 PM, David Sterba wrote:
> On Thu, Mar 10, 2016 at 08:57:12AM +0800, Qu Wenruo wrote:
>>> The ioctl FIDEDUPERANGE and the tool duperemove both use "dupe".
>>> It would be nice if we could be consistent and all use the same
>>> abbreviation.
>>
>> Yes, current kernel VFS level offline dedup uses the name "dedupe".
>> But on the other hand, ZFS uses the name "dedup" for their online dedup.
>>
>> And personally speaking, I'd like some difference to distinguish inline
>> dedup and offline dedup.
>> In that case, the extra "e" seems somewhat useful.
>> With "e", it's intended for offline use. Without "e", it's intended for
>> online use.
>
> Such difference is very subtle and I think we should stick to just one
> spelling, which shall be 'dedupe'.
OK, I'll change them to 'dedupe' in next bug fix version.
Thanks,
Qu
next prev parent reply other threads:[~2016-03-12 8:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 5:42 [GIT PULL][PATCH v7 00/19][For 4.6] Btrfs: Add inband (write time) de-duplication framework Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 01/20] btrfs: dedup: Introduce dedup framework and its header Qu Wenruo
2016-03-09 21:27 ` NeilBrown
2016-03-10 0:57 ` Qu Wenruo
2016-03-11 11:43 ` David Sterba
2016-03-12 8:16 ` Qu Wenruo [this message]
2016-03-13 5:16 ` Qu Wenruo
2016-03-13 11:33 ` NeilBrown
2016-03-13 16:55 ` Duncan
2016-03-15 22:08 ` Nicholas D Steeves
2016-03-15 23:19 ` Duncan
2016-02-18 5:42 ` [PATCH v7 02/20] btrfs: dedup: Introduce function to initialize dedup info Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 03/20] btrfs: dedup: Introduce function to add hash into in-memory tree Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 04/20] btrfs: dedup: Introduce function to remove hash from " Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 05/20] btrfs: delayed-ref: Add support for increasing data ref under spinlock Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 06/20] btrfs: dedup: Introduce function to search for an existing hash Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 07/20] btrfs: dedup: Implement btrfs_dedup_calc_hash interface Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 08/20] btrfs: ordered-extent: Add support for dedup Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 09/20] btrfs: dedup: Inband in-memory only de-duplication implement Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 10/20] btrfs: dedup: Add basic tree structure for on-disk dedup method Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 11/20] btrfs: dedup: Introduce interfaces to resume and cleanup dedup info Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 12/20] btrfs: dedup: Add support for on-disk hash search Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 13/20] btrfs: dedup: Add support to delete hash for on-disk backend Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 14/20] btrfs: dedup: Add support for adding " Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 15/20] btrfs: dedup: Add ioctl for inband deduplication Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 16/20] btrfs: dedup: add an inode nodedup flag Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 17/20] btrfs: dedup: add a property handler for online dedup Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 18/20] btrfs: dedup: add per-file online dedup control Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 19/20] btrfs: try more times to alloc metadata reserve space Qu Wenruo
2016-02-18 5:42 ` [PATCH v7 20/20] btrfs: dedup: Fix a bug when running inband dedup with balance Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E3D070.3020005@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=neilb@suse.com \
--cc=quwenruo@cn.fujitsu.com \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).