From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs-progs: subvolume functions reorg
Date: Fri, 18 Mar 2016 16:54:24 +0800 [thread overview]
Message-ID: <56EBC240.40306@oracle.com> (raw)
In-Reply-To: <20160317141945.GU21722@twin.jikos.cz>
On 03/17/2016 10:19 PM, David Sterba wrote:
> On Wed, Mar 16, 2016 at 10:14:33PM +0800, Anand Jain wrote:
>> Makes few subvol related functions usable outside of subvol
>> command set.
>>
>> This is a preparatory patch for encryption support. The changes
>> here are:
>>
>> Created new file subvolume.c
>> Created btrfs_get_subvol_info() from parts of cmd_subvol_show()
>> Moved get_subvol_name() to subvolume.c
>> Moved test_issubvolume() to subvolume.c
>> Created subvolume.h to define the above functions.
>
> Such helpers are in utils.[ch], eg. there's test_issubvolname.
You meant to move them/it to subvolume.c/h right ?
> get_subvol_name could be renamed,
will do.
> factoring btrfs_get_subvol_info looks good.
>
> So far the internal interfaces are not tidy,
> so everything goes to utils.
yes. very true.
> It should be easier for you if you need to do some code
> rearrangements.
Sure. Thanks for suggesting. Will see what I can find.
- Anand
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-03-18 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 14:14 [PATCH v2] btrfs-progs: subvolume functions reorg Anand Jain
2016-03-17 14:19 ` David Sterba
2016-03-18 8:54 ` Anand Jain [this message]
2016-03-18 13:31 ` David Sterba
2016-03-21 7:24 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EBC240.40306@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).