From: Anand Jain <anand.jain@oracle.com>
To: Flex Liu <fliu@novell.com>, David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org, Chris Mason <clm@fb.com>,
Josef Bacik <jbacik@fb.com>,
linux-kernel@vger.kernel.org, Petr Tesarik <ptesarik@suse.com>,
Flex Liu <fliu@suse.com>
Subject: Re: [PATCH 1/1] Btrfs: Code Cleanup
Date: Mon, 21 Mar 2016 16:29:34 +0800 [thread overview]
Message-ID: <56EFB0EE.6030605@oracle.com> (raw)
In-Reply-To: <1458457871-25512-1-git-send-email-fliu@novell.com>
Hi Flex,
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 366b335..5c16f04 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -2325,7 +2325,10 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path)
> if (seeding_dev) {
> sb->s_flags &= ~MS_RDONLY;
This is not undone in the failure code. Theoretically
it should report error during unmount, did you notice ?
(in general, $subject can be more specific).
Thanks, Anand
> ret = btrfs_prepare_sprout(root);
> - BUG_ON(ret); /* -ENOMEM */
> + if (ret) {
> + btrfs_abort_transaction(trans, root, ret);
> + goto error_trans;
> + }
> }
>
> device->fs_devices = root->fs_info->fs_devices;
>
next prev parent reply other threads:[~2016-03-21 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 7:11 [PATCH 1/1] Btrfs: Code Cleanup Flex Liu
2016-03-21 8:29 ` Anand Jain [this message]
2016-03-24 15:03 ` David Sterba
2016-03-24 15:08 ` Petr Tesarik
2016-03-24 16:09 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EFB0EE.6030605@oracle.com \
--to=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=fliu@novell.com \
--cc=fliu@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptesarik@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).