btrfs fi du ERROR

btrfs fi du ERROR

[Martin Volf]

Hello,

I have just tried the new "btrfs fi du" command from btrfs-progs 4.5
on 4.4.6 linux kernel, and it gave me:

# btrfs fi du /bin
     Total   Exclusive  Set shared  Filename
(many lines of output for individual files, probably OK)
...
ERROR: cannot check space of '/bin': Unknown error -1

The -1 is ETXTBSY in this case:

# strace -o log btrfs fi du /bin &>/dev/null; tail log

newfstatat(3, "login", {st_mode=S_IFREG|0755, st_size=44784, ...}, 0) = 0
stat("/bin/login", {st_mode=S_IFREG|0755, st_size=44784, ...}) = 0
open("/bin/login", O_RDWR)              = -1 ETXTBSY (Text file busy)
close(3)                                = 0
write(2, "ERROR: ", 7)                  = 7
write(2, "cannot check space of '/bin': Un"..., 46) = 46
write(2, "\n", 1)                       = 1
write(1, "     Total   Exclusive  Set shar"..., 3161) = 3161
exit_group(1)                           = ?
+++ exited with 1 +++

Read-only snapshots give Unknown error -1 too, this time EROFS.

Is it expected?

-- 
Martin Volf

Re: btrfs fi du ERROR

[Austin S. Hemmelgarn]

On 2016-03-21 02:37, Martin Volf wrote:
> Hello,
>
> I have just tried the new "btrfs fi du" command from btrfs-progs 4.5
> on 4.4.6 linux kernel, and it gave me:
>
> # btrfs fi du /bin
>       Total   Exclusive  Set shared  Filename
> (many lines of output for individual files, probably OK)
> ...
> ERROR: cannot check space of '/bin': Unknown error -1
>
> The -1 is ETXTBSY in this case:
>
> # strace -o log btrfs fi du /bin &>/dev/null; tail log
>
> newfstatat(3, "login", {st_mode=S_IFREG|0755, st_size=44784, ...}, 0) = 0
> stat("/bin/login", {st_mode=S_IFREG|0755, st_size=44784, ...}) = 0
> open("/bin/login", O_RDWR)              = -1 ETXTBSY (Text file busy)
> close(3)                                = 0
> write(2, "ERROR: ", 7)                  = 7
> write(2, "cannot check space of '/bin': Un"..., 46) = 46
> write(2, "\n", 1)                       = 1
> write(1, "     Total   Exclusive  Set shar"..., 3161) = 3161
> exit_group(1)                           = ?
> +++ exited with 1 +++
>
> Read-only snapshots give Unknown error -1 too, this time EROFS.
>
> Is it expected?
>
Given that we're apparently trying to open the file with O_RDWR, yes 
that is expected.  What's not expected is that we're opening the file 
writable...

I'll see if I can get a patch put together some time today to fix that.

Re: btrfs fi du ERROR

[Austin S. Hemmelgarn]

On 2016-03-21 02:37, Martin Volf wrote:
> Hello,
>
> I have just tried the new "btrfs fi du" command from btrfs-progs 4.5
> on 4.4.6 linux kernel, and it gave me:
>
> # btrfs fi du /bin
>       Total   Exclusive  Set shared  Filename
> (many lines of output for individual files, probably OK)
> ...
> ERROR: cannot check space of '/bin': Unknown error -1
>
> The -1 is ETXTBSY in this case:
>
> # strace -o log btrfs fi du /bin &>/dev/null; tail log
>
> newfstatat(3, "login", {st_mode=S_IFREG|0755, st_size=44784, ...}, 0) = 0
> stat("/bin/login", {st_mode=S_IFREG|0755, st_size=44784, ...}) = 0
> open("/bin/login", O_RDWR)              = -1 ETXTBSY (Text file busy)
> close(3)                                = 0
> write(2, "ERROR: ", 7)                  = 7
> write(2, "cannot check space of '/bin': Un"..., 46) = 46
> write(2, "\n", 1)                       = 1
> write(1, "     Total   Exclusive  Set shar"..., 3161) = 3161
> exit_group(1)                           = ?
> +++ exited with 1 +++
>
> Read-only snapshots give Unknown error -1 too, this time EROFS.
>
> Is it expected?
>
Thanks for reporting this, I've sent a patch to fix it.