From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH] fstests: add btrfs test for fsync after snapshot deletion
Date: Fri, 25 Mar 2016 12:58:52 +0100 [thread overview]
Message-ID: <56F527FC.9020007@googlemail.com> (raw)
In-Reply-To: <20160325035306.GX11419@eguan.usersys.redhat.com>
On 03/25/16 04:53, Eryu Guan wrote:
> Test fails on v4.5 kernel as expected, but I failed to compile btrfs
> after applying this patch, seems btrfs_must_commit_transaction was not
> defined anywhere (I did grep it through the kernel tree, nothing showed
> up), did I miss anything?
>
> fs/btrfs/tree-log.c: In function ‘check_parent_dirs_for_sync’:
> fs/btrfs/tree-log.c:4836:4: error: implicit declaration of function ‘btrfs_must_commit_transaction’ [-Werror=implicit-function-declaration]
> if (btrfs_must_commit_transaction(trans, inode))
> ^
> cc1: some warnings being treated as errors
> make[1]: *** [fs/btrfs/tree-log.o] Error 1
> make: *** [_module_fs/btrfs] Error 2
It was defined in a previous patch for 4.6:
https://git.kernel.org/cgit/linux/kernel/git/mason/linux-btrfs.git/commit/?h=for-linus-4.6&id=2be63d5ce929603d4e7cedabd9e992eb34a0ff95
-h
next prev parent reply other threads:[~2016-03-25 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 17:07 [PATCH] fstests: add btrfs test for fsync after snapshot deletion fdmanana
2016-03-24 20:08 ` [PATCH v2] " fdmanana
2016-03-25 14:04 ` Eryu Guan
2016-03-25 3:53 ` [PATCH] " Eryu Guan
2016-03-25 11:58 ` Holger Hoffstätte [this message]
2016-03-25 14:00 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F527FC.9020007@googlemail.com \
--to=holger.hoffstaette@googlemail.com \
--cc=eguan@redhat.com \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).