From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <fdmanana@gmail.com>, Duncan <1i5t5.duncan@cox.net>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>
Subject: Re: [PATCH] Btrfs: fix loading of orphan roots leading to BUG_ON
Date: Thu, 14 Apr 2016 13:34:40 +0800 [thread overview]
Message-ID: <570F2BF0.2060409@cn.fujitsu.com> (raw)
In-Reply-To: <CAL3q7H7zawdrwbnnwr4nRg5PTj3BqRjDpZJo+idxCANMs185LA@mail.gmail.com>
Ping?
Cc: Chris and David
It seems that this fix is missing in 4.6 merge window.
Or did I miss something?
Thanks,
Qu
Filipe Manana wrote on 2016/03/03 09:10 +0000:
> On Thu, Mar 3, 2016 at 4:31 AM, Duncan <1i5t5.duncan@cox.net> wrote:
>> fdmanana posted on Wed, 02 Mar 2016 15:49:38 +0000 as excerpted:
>>
>>> When looking for orphan roots during mount we can end up hitting a
>>> BUG_ON() (at root-item.c:btrfs_find_orphan_roots()) if a log tree is
>>> replayed and qgroups are enabled.
>>
>> This should hit 4.6, right? Will it hit 4.5 before release?
>
> It's not the first time you do a similar question, and if it's
> targeted at me, all I can tell you is I don't know. It's the
> maintainers (Chris, Josef, David) who decide when to pick patches and
> for which releases.
>
>>
>> Because I wasn't sure of current quota functionality status, but this bug
>> obviously resets the counter on my ongoing "two kernel cycles with no
>> known quota bugs before you try to use quotas" recommendation.
>
> You shouldn't spread such affirmation with such a level of certainty
> every time a user reports a problem.
> There are many bugs affecting the last 2 to 3 releases, but there are
> also many bugs present since btrfs was added to the linux kernel tree,
> and many others present for 2+ years, etc.
>
>>
>> Meanwhile, what /is/ current quota feature status? Other than this bug,
>> is it now considered known bug free, or is more quota reworking and/or
>> bug fixing known to be needed for 4.6 and beyond?
>>
>> IOW, given that two release cycles no known bugs counter, are we
>> realistically looking at that being 4.8, or are we now looking at 4.9 or
>> beyond for reasonable quota stability?
>
> I don't know. I generally don't look actively look at qgroups, and I'm
> not a user either.
> You can only take conclusions based on user bug reports. Probably
> there aren't more bugs for qgroups than there are for send/receive or
> even non-btrfs specific features for example.
>
>>
>> --
>> Duncan - List replies preferred. No HTML msgs.
>> "Every nonfree program has a lord, a master --
>> and if you use the program, he is your master." Richard Stallman
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
next prev parent reply other threads:[~2016-04-14 5:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 15:49 [PATCH] Btrfs: fix loading of orphan roots leading to BUG_ON fdmanana
2016-03-03 4:31 ` Duncan
2016-03-03 6:26 ` Qu Wenruo
2016-03-03 7:44 ` Duncan
2016-03-03 8:04 ` Qu Wenruo
2016-03-03 9:10 ` Filipe Manana
2016-04-14 5:34 ` Qu Wenruo [this message]
2016-04-14 9:21 ` Filipe Manana
2016-04-15 1:17 ` Qu Wenruo
2016-04-15 9:39 ` David Sterba
2016-03-03 6:29 ` Qu Wenruo
2016-03-03 9:17 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570F2BF0.2060409@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=1i5t5.duncan@cox.net \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=fdmanana@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).