From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org, yauhen.kharuzhy@zavadatar.com
Subject: Re: [PATCH] btrfs: cleanup assigning next active device with a check
Date: Mon, 2 May 2016 07:05:07 +0800 [thread overview]
Message-ID: <57268BA3.3040701@oracle.com> (raw)
In-Reply-To: <20160425151514.GC29353@twin.jikos.cz>
On 04/25/2016 11:15 PM, David Sterba wrote:
> On Mon, Apr 18, 2016 at 07:25:52PM +0800, Anand Jain wrote:
>> Creates helper fucntion as needed by the device delete
>> and replace operations. Also now it checks if the next
>> device being assigned is an active device.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> --- a/fs/btrfs/volumes.c
>> +++ b/fs/btrfs/volumes.c
>> @@ -1684,10 +1684,40 @@ out:
>> return ret;
>> }
>>
>> +struct btrfs_device *btrfs_find_next_active_device(struct btrfs_fs_devices *fs_devs,
>> + struct btrfs_device *device)
>
>> +
>> +void btrfs_assign_next_active_device(struct btrfs_fs_info *fs_info,
>> + struct btrfs_device *device, struct btrfs_device *this_dev)
>
> Please add comments what the functions do so that one does not need to
> read the whole function to figure it out.
Right. Added comments. and BUG_ON(). Thanks,
Anand
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-05-01 23:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 11:25 [PATCH] btrfs: cleanup assigning next active device with a check Anand Jain
2016-04-25 15:15 ` David Sterba
2016-05-01 23:05 ` Anand Jain [this message]
2016-05-01 23:02 ` [PATCH v2] " Anand Jain
2016-05-02 15:26 ` David Sterba
2016-05-03 10:01 ` Anand Jain
2016-05-03 17:47 ` David Sterba
2016-05-03 23:31 ` Anand Jain
2016-05-04 9:00 ` David Sterba
2016-05-04 8:44 ` David Sterba
2016-05-03 9:44 ` [PATCH] " Anand Jain
-- strict thread matches above, loose matches on Subject: below --
2016-04-18 10:46 Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57268BA3.3040701@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=yauhen.kharuzhy@zavadatar.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).