* [PATCH] btrfs: fix incorrect error message in check_dev_extent_item()
@ 2026-02-17 10:34 Mark Harmstone
2026-02-17 17:04 ` Boris Burkov
2026-02-17 21:01 ` Qu Wenruo
0 siblings, 2 replies; 3+ messages in thread
From: Mark Harmstone @ 2026-02-17 10:34 UTC (permalink / raw)
To: linux-btrfs, wqu; +Cc: Mark Harmstone, Chris Mason
Fix the error message in check_dev_extent_item(), when an overlapping
stripe is encountered. For dev extents, objectid is the disk number and
offset the physical address, so prev_key->objectid should actually be
prev_key->offset.
(I can't take any credit for this one - this was discovered by Chris and
his friend Claude.)
Signed-off-by: Mark Harmstone <mark@harmstone.com>
Suggested-by: Chris Mason <clm@fb.com>
Fixes: 008e2512dc56 ("btrfs: tree-checker: add dev extent item checks")
---
fs/btrfs/tree-checker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
index 452394b34d01..9774779f060b 100644
--- a/fs/btrfs/tree-checker.c
+++ b/fs/btrfs/tree-checker.c
@@ -1921,7 +1921,7 @@ static int check_dev_extent_item(const struct extent_buffer *leaf,
if (unlikely(prev_key->offset + prev_len > key->offset)) {
generic_err(leaf, slot,
"dev extent overlap, prev offset %llu len %llu current offset %llu",
- prev_key->objectid, prev_len, key->offset);
+ prev_key->offset, prev_len, key->offset);
return -EUCLEAN;
}
}
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: fix incorrect error message in check_dev_extent_item()
2026-02-17 10:34 [PATCH] btrfs: fix incorrect error message in check_dev_extent_item() Mark Harmstone
@ 2026-02-17 17:04 ` Boris Burkov
2026-02-17 21:01 ` Qu Wenruo
1 sibling, 0 replies; 3+ messages in thread
From: Boris Burkov @ 2026-02-17 17:04 UTC (permalink / raw)
To: Mark Harmstone; +Cc: linux-btrfs, wqu, Chris Mason
On Tue, Feb 17, 2026 at 10:34:08AM +0000, Mark Harmstone wrote:
> Fix the error message in check_dev_extent_item(), when an overlapping
> stripe is encountered. For dev extents, objectid is the disk number and
> offset the physical address, so prev_key->objectid should actually be
> prev_key->offset.
>
> (I can't take any credit for this one - this was discovered by Chris and
> his friend Claude.)
>
> Signed-off-by: Mark Harmstone <mark@harmstone.com>
> Suggested-by: Chris Mason <clm@fb.com>
Reviewed-by: Boris Burkov <boris@bur.io>
> Fixes: 008e2512dc56 ("btrfs: tree-checker: add dev extent item checks")
> ---
> fs/btrfs/tree-checker.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
> index 452394b34d01..9774779f060b 100644
> --- a/fs/btrfs/tree-checker.c
> +++ b/fs/btrfs/tree-checker.c
> @@ -1921,7 +1921,7 @@ static int check_dev_extent_item(const struct extent_buffer *leaf,
> if (unlikely(prev_key->offset + prev_len > key->offset)) {
> generic_err(leaf, slot,
> "dev extent overlap, prev offset %llu len %llu current offset %llu",
> - prev_key->objectid, prev_len, key->offset);
> + prev_key->offset, prev_len, key->offset);
> return -EUCLEAN;
> }
> }
> --
> 2.52.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: fix incorrect error message in check_dev_extent_item()
2026-02-17 10:34 [PATCH] btrfs: fix incorrect error message in check_dev_extent_item() Mark Harmstone
2026-02-17 17:04 ` Boris Burkov
@ 2026-02-17 21:01 ` Qu Wenruo
1 sibling, 0 replies; 3+ messages in thread
From: Qu Wenruo @ 2026-02-17 21:01 UTC (permalink / raw)
To: Mark Harmstone, linux-btrfs, wqu; +Cc: Chris Mason
在 2026/2/17 21:04, Mark Harmstone 写道:
> Fix the error message in check_dev_extent_item(), when an overlapping
> stripe is encountered. For dev extents, objectid is the disk number and
> offset the physical address, so prev_key->objectid should actually be
> prev_key->offset.
>
> (I can't take any credit for this one - this was discovered by Chris and
> his friend Claude.)
>
> Signed-off-by: Mark Harmstone <mark@harmstone.com>
> Suggested-by: Chris Mason <clm@fb.com>
> Fixes: 008e2512dc56 ("btrfs: tree-checker: add dev extent item checks")
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/tree-checker.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
> index 452394b34d01..9774779f060b 100644
> --- a/fs/btrfs/tree-checker.c
> +++ b/fs/btrfs/tree-checker.c
> @@ -1921,7 +1921,7 @@ static int check_dev_extent_item(const struct extent_buffer *leaf,
> if (unlikely(prev_key->offset + prev_len > key->offset)) {
> generic_err(leaf, slot,
> "dev extent overlap, prev offset %llu len %llu current offset %llu",
> - prev_key->objectid, prev_len, key->offset);
> + prev_key->offset, prev_len, key->offset);
> return -EUCLEAN;
> }
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-17 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-17 10:34 [PATCH] btrfs: fix incorrect error message in check_dev_extent_item() Mark Harmstone
2026-02-17 17:04 ` Boris Burkov
2026-02-17 21:01 ` Qu Wenruo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox