From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: Anand Jain <anand.jain@oracle.com>, linux-btrfs@vger.kernel.org
Cc: clm@fb.com, dsterba@suse.com, xiaolong.ye@intel.com
Subject: Re: [PATCH v2 2/2] btrfs: wait for bdev put
Date: Tue, 21 Jun 2016 13:46:52 +0200 [thread overview]
Message-ID: <5769292C.6030208@applied-asynchrony.com> (raw)
In-Reply-To: <1466504648-2937-1-git-send-email-anand.jain@oracle.com>
On 06/21/16 12:24, Anand Jain wrote:
> From: Anand Jain <Anand.Jain@oracle.com>
>
> Further to the commit
> bc178622d40d87e75abc131007342429c9b03351
> btrfs: use rcu_barrier() to wait for bdev puts at unmount
>
> This patch implements a method to time wait on the __free_device()
> which actually does the bdev put. This is needed as the user space
> running 'btrfs fi show -d' immediately after the replace and
> unmount, is still reading older information from the device.
>
> mail-archive.com/linux-btrfs@vger.kernel.org/msg54188.html
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> [updates: bc178622d40d87e75abc131007342429c9b03351]
> ---
> v2: Also to make sure bdev_closing is set it needs rcu_barrier(),
> restored rcu_barrier().
Looks like this one works reliably again. ;)
Tested with a slow disk, no long unmounts or timeout messages.
Tested-by: Holger Hoffstätte <holger.hoffstaette@applied-asynchrony.com>
thanks!
Holger
next prev parent reply other threads:[~2016-06-21 11:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 9:27 [PULL] Btrfs for 4.7, part 2 David Sterba
2016-05-27 0:14 ` Chris Mason
2016-05-27 11:18 ` David Sterba
2016-05-27 14:35 ` Chris Mason
2016-05-27 15:42 ` Chris Mason
2016-05-28 5:14 ` Anand Jain
2016-05-29 12:21 ` Chris Mason
2016-06-14 10:52 ` Anand Jain
2016-06-14 10:55 ` [PATCH 1/2] btrfs: reorg btrfs_close_one_device() Anand Jain
2016-06-14 10:55 ` [PATCH 2/2] btrfs: wait for bdev put Anand Jain
2016-06-18 16:34 ` Holger Hoffstätte
2016-06-20 8:33 ` Anand Jain
2016-06-21 10:24 ` [PATCH v2 " Anand Jain
2016-06-21 11:46 ` Holger Hoffstätte [this message]
2016-06-21 13:00 ` Chris Mason
2016-06-22 10:18 ` Anand Jain
2016-06-22 21:47 ` Chris Mason
2016-06-23 13:07 ` Anand Jain
2016-06-23 12:54 ` [PATCH v3 2/2] btrfs: make sure device is synced before return Anand Jain
2016-06-23 14:27 ` Chris Mason
2016-07-08 14:13 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5769292C.6030208@applied-asynchrony.com \
--to=holger@applied-asynchrony.com \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).