From: Nikolay Borisov <kernel@kyup.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org, clm@fb.com
Subject: Re: On shrinkable caches
Date: Thu, 23 Jun 2016 13:03:54 +0300 [thread overview]
Message-ID: <576BB40A.8030408@kyup.com> (raw)
In-Reply-To: <20160623094347.GX4915@twin.jikos.cz>
On 06/23/2016 12:43 PM, David Sterba wrote:
> On Mon, Jun 20, 2016 at 02:26:12PM +0300, Nikolay Borisov wrote:
>> I have a question regarding the SLAB_RECLAIM_ACCOUNT flag with which
>> BTRFS caches are created. Currently there isn't a single usage of
>> register_shrinker under fs/btrfs.
>
> The SLAB_RECLAIM_ACCOUNT flag has been there since the first versions in
> 2007 (when shrinkeres did not exist) but I can't find any specific
> reason why.
>
>> Apart from the inode cache which is
>> being shrunk from the generic super_cache_scan I don't think the memory
>> used for those caches should be accounted as reclaimable?
>
> I agree, in most cases I don't see any possibility to reclaim the
> objects earlier than the explicit free.
If that's the case, then I'll be happy to send a patch.
prev parent reply other threads:[~2016-06-23 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 11:26 On shrinkable caches Nikolay Borisov
2016-06-23 9:43 ` David Sterba
2016-06-23 10:03 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576BB40A.8030408@kyup.com \
--to=kernel@kyup.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).