From: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
To: <dsterba@suse.cz>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] btrfs: fix free space calculation in dump_space_info()
Date: Mon, 11 Jul 2016 19:27:44 +0800 [thread overview]
Message-ID: <578382B0.3000702@cn.fujitsu.com> (raw)
In-Reply-To: <20160708142832.GJ13336@twin.jikos.cz>
hello,
On 07/08/2016 10:28 PM, David Sterba wrote:
> On Wed, Jul 06, 2016 at 06:16:06PM +0800, Wang Xiaoguang wrote:
>> hello,
>>
>> On 07/05/2016 01:10 AM, David Sterba wrote:
>>> On Wed, Jun 29, 2016 at 01:12:16PM +0800, Wang Xiaoguang wrote:
>>>
>>> Can you please describe in more detail what is this patch fixing?
>> In original dump_space_info(), free space info is calculated by
>> info->total_bytes - info->bytes_used - info->bytes_pinned -
>> info->bytes_reserved - info->bytes_readonly,
>> but I think free space info should also minus info->bytes_may_use :)
> Not really what I expected. The change is correct but the changelog
> should say something "the 'used space' formula is missing the
> bytes_may_used, that is used elsewhere eg. __reserve_metadata_bytes or
> space_info_add_old_bytes". That way I have something to verify during
> the review.
Sorry, later I'll try to make my patches more cleaner, thanks.
Regards,
Xiaoguang Wang
>
>
prev parent reply other threads:[~2016-07-11 11:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 5:12 [PATCH 2/2] btrfs: fix free space calculation in dump_space_info() Wang Xiaoguang
2016-07-04 17:10 ` David Sterba
2016-07-06 10:16 ` Wang Xiaoguang
2016-07-08 14:28 ` David Sterba
2016-07-11 11:27 ` Wang Xiaoguang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578382B0.3000702@cn.fujitsu.com \
--to=wangxg.fnst@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).