From: Qu Wenruo <wqu@suse.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH RFC] common/btrfs: use _scratch_cycle_mount to ensure all page caches are dropped
Date: Fri, 9 Jun 2023 07:57:37 +0800 [thread overview]
Message-ID: <5790cd5a-04d9-bfe9-a8cc-0c09f784222d@suse.com> (raw)
In-Reply-To: <ZIHGb+KyYW72MVzp@infradead.org>
On 2023/6/8 20:15, Christoph Hellwig wrote:
> On Thu, Jun 08, 2023 at 07:48:36PM +0800, Qu Wenruo wrote:
>> echo 3 > /proc/sys/vm/drop_caches
>> + # Above drop_caches doesn't seem to drop every pages on aarch64 with
>> + # 64K page size.
>> + # So here as a workaround, cycle mount the SCRATCH_MNT to ensure
>> + # the cache are dropped.
>> + _scratch_cycle_mount
>
> The _scratch_cycle_mount looks ok to me, but if we do that, there is
> really no point in doing the drop_caches as well.
Yep, we can remove that line. It's mostly a reminder for me to dig out
why that drop_caches doesn't work as expected.
Thanks,
Qu
next prev parent reply other threads:[~2023-06-08 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 11:48 [PATCH RFC] common/btrfs: use _scratch_cycle_mount to ensure all page caches are dropped Qu Wenruo
2023-06-08 12:15 ` Christoph Hellwig
2023-06-08 23:57 ` Qu Wenruo [this message]
2023-06-10 6:46 ` Zorro Lang
2023-06-10 7:25 ` Qu Wenruo
2023-06-19 16:13 ` Filipe Manana
2023-06-20 1:07 ` Qu Wenruo
2023-06-20 9:13 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5790cd5a-04d9-bfe9-a8cc-0c09f784222d@suse.com \
--to=wqu@suse.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox