Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Graham Cobb <g.btrfs@cobb.uk.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: fi defrag: change default extent target size to 32 MiB
Date: Thu, 28 Jul 2016 12:28:27 +0100	[thread overview]
Message-ID: <5799EC5B.2050108@cobb.uk.net> (raw)
In-Reply-To: <1469704629-25512-1-git-send-email-dsterba@suse.com>

On 28/07/16 12:17, David Sterba wrote:
> diff --git a/cmds-filesystem.c b/cmds-filesystem.c
> index ef1f550b51c0..6b381c582ea7 100644
> --- a/cmds-filesystem.c
> +++ b/cmds-filesystem.c
> @@ -968,7 +968,7 @@ static const char * const cmd_filesystem_defrag_usage[] = {
>  	"-f             flush data to disk immediately after defragmenting",
>  	"-s start       defragment only from byte onward",
>  	"-l len         defragment only up to len bytes",
> -	"-t size        target extent size hint",
> +	"-t size        target extent size hint (default: 32 MiB)",

As a user... might it be better to say the default is 32M as that is the
format the option requires?


  reply	other threads:[~2016-07-28 11:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 11:17 [PATCH] btrfs-progs: fi defrag: change default extent target size to 32 MiB David Sterba
2016-07-28 11:28 ` Graham Cobb [this message]
2016-07-28 11:35   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5799EC5B.2050108@cobb.uk.net \
    --to=g.btrfs@cobb.uk.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox