From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.iobjects.de ([188.40.134.68]:48494 "EHLO mail02.iobjects.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750700AbcI2MxB (ORCPT ); Thu, 29 Sep 2016 08:53:01 -0400 Subject: Re: [PATCH v2 0/6] Btrfs: free space tree and sanity test fixes To: Anatoly Pugachev , dsterba@suse.cz, Omar Sandoval , linux-btrfs@vger.kernel.org, kernel-team@fb.com, Chandan Rajendra , bo.li.liu@oracle.com References: <20160925075524.GA3870@yogzotot> <20160926175000.GF16983@twin.jikos.cz> <20160929122148.GA22109@yogzotot> Cc: fstests@vger.kernel.org From: =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= Message-ID: <57ED0EAA.7070206@applied-asynchrony.com> Date: Thu, 29 Sep 2016 14:52:58 +0200 MIME-Version: 1.0 In-Reply-To: <20160929122148.GA22109@yogzotot> Content-Type: text/plain; charset=utf-8 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 09/29/16 14:21, Anatoly Pugachev wrote: >> ... >> >> This is fixed by patch >> >> "Btrfs: remove unnecessary btrfs_mark_buffer_dirty in split_leaf" >> >> that's in the 4.9 queue. Other than that, the self-tests seem to pass, >> thanks for the test. Would be good if you can test with the mentioned >> patch included or without integrity checker. Thanks for testing. > > updated git kernel to v4.8-rc8-8-gae6dd8d , applied this > "Btrfs: free space tree and sanity test fixes" patchset and added/applied > "Btrfs: remove unnecessary btrfs_mark_buffer_dirty in split_leaf" : > (snip) > Sep 29 00:40:55 ttip kernel: BTRFS: device fsid 7bb81df9-0e2b-47f2-81ff-c08502d38da6 devid 1 transid 5 /dev/loop4 > Sep 29 00:41:30 ttip kernel: BTRFS info (device loop4): disk space caching is enabled > Sep 29 00:41:30 ttip kernel: BTRFS info (device loop4): has skinny extents > Sep 29 00:41:30 ttip kernel: BTRFS info (device loop4): flagging fs with big metadata feature > Sep 29 00:41:30 ttip kernel: BTRFS info (device loop4): creating UUID tree > Sep 29 00:41:31 ttip kernel: BTRFS: device fsid d0ee7ca3-3be0-465f-857b-19e681181923 devid 1 transid 5 /dev/loop0 > Sep 29 00:41:32 ttip kernel: BTRFS info (device loop0): enabling free space tree > Sep 29 00:41:32 ttip kernel: BTRFS info (device loop0): using free space tree > Sep 29 00:41:32 ttip kernel: BTRFS info (device loop0): has skinny extents > Sep 29 00:41:32 ttip kernel: BTRFS info (device loop0): flagging fs with big metadata feature > Sep 29 00:41:32 ttip kernel: BTRFS info (device loop0): creating free space tree > Sep 29 00:41:32 ttip kernel: BTRFS info (device loop0): setting 1 ro feature flag > Sep 29 00:41:32 ttip kernel: BTRFS info (device loop0): setting 2 ro feature flag > Sep 29 00:41:32 ttip kernel: BTRFS info (device loop0): creating UUID tree > Sep 29 00:41:32 ttip kernel: BTRFS critical (device loop4): corrupt leaf, non-root leaf's nritems is 0: block=29556736,root=1, slot=0 > Sep 29 00:41:32 ttip kernel: BTRFS info (device loop4): leaf 29556736 total ptrs 0 free space 16283 > Sep 29 00:41:32 ttip kernel: BTRFS: assertion failed: 0, file: fs/btrfs/disk-io.c, line: 4059kernel BUG at fs/btrfs/ctree.h:3369! Try to add https://patchwork.kernel.org/patch/9332707/ aka "Btrfs: improve check_node to avoid reading corrupted nodes" which should return -EIO and prevent the BUG(). -h