From: Johannes Thumshirn <jthumshirn@suse.de>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/6] btrfs: Remove fs_info from struct async_cow
Date: Wed, 20 Feb 2019 16:25:25 +0100 [thread overview]
Message-ID: <587b0505-56b4-f128-0dc1-fc48a5ad2b48@suse.de> (raw)
In-Reply-To: <20190220151143.19057-3-nborisov@suse.com>
On 20/02/2019 16:11, Nikolay Borisov wrote:
> We always pass an inode alongside async_cow. fs_info can be referenced
> from this inode so it makes the explicit fs_info member in
> struct async_cow redundant, remove it. No functional changes.
[...]
> @@ -1151,13 +1150,10 @@ static noinline void async_cow_start(struct btrfs_work *work)
> */
> static noinline void async_cow_submit(struct btrfs_work *work)
> {
> - struct btrfs_fs_info *fs_info;
> - struct async_cow *async_cow;
> + struct async_cow *async_cow = container_of(work, struct async_cow, work);
> + struct btrfs_fs_info *fs_info = btrfs_work_owner(work);
> unsigned long nr_pages;
Nit, in your changelog you write that fs_info can be retrieved from the
inode that is passed with 'struct async_cow' but you're getting fs_info
from the btrfs_work structure.
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-02-20 15:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 15:11 [PATCH v2 0/6] Compressed path cleanups Nikolay Borisov
2019-02-20 15:11 ` [PATCH v2 1/6] btrfs: Refactor cow_file_range_async Nikolay Borisov
2019-02-20 15:51 ` Johannes Thumshirn
2019-02-20 15:11 ` [PATCH v2 2/6] btrfs: Remove fs_info from struct async_cow Nikolay Borisov
2019-02-20 15:25 ` Johannes Thumshirn [this message]
2019-02-20 15:29 ` Nikolay Borisov
2019-02-20 15:11 ` [PATCH v2 3/6] btrfs: Make compress_file_range take only " Nikolay Borisov
2019-02-20 15:27 ` Johannes Thumshirn
2019-02-21 11:55 ` Nikolay Borisov
2019-02-21 13:08 ` Johannes Thumshirn
2019-02-20 15:11 ` [PATCH v2 4/6] btrfs: Replace clear_extent_bit with unlock_extent Nikolay Borisov
2019-02-20 15:29 ` Johannes Thumshirn
2019-02-20 15:11 ` [PATCH v2 5/6] btrfs: Set iotree only once in submit_compressed_extents Nikolay Borisov
2019-02-20 15:33 ` Johannes Thumshirn
2019-02-20 15:11 ` [PATCH v2 6/6] btrfs: Factor out common extent locking code " Nikolay Borisov
2019-02-20 15:35 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=587b0505-56b4-f128-0dc1-fc48a5ad2b48@suse.de \
--to=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).