From: Anand Jain <anand.jain@oracle.com>
To: Boris Burkov <boris@bur.io>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com,
fstests@vger.kernel.org
Subject: Re: [PATCH v4 0/6] btrfs: simple quotas fstests
Date: Sat, 30 Sep 2023 17:45:54 +0800 [thread overview]
Message-ID: <59124721-0e07-7b5f-d650-d58d9ce9fcb2@oracle.com> (raw)
In-Reply-To: <cover.1695942727.git.boris@bur.io>
On 29/09/2023 07:16, Boris Burkov wrote:
> Add a new test for specific squota scenarios (btrfs/301)
>
> Also made modifications for passing existing qgroups tests when possible
> and for passing all tests with simple quota enabled via mkfs and with
> squota-aware `btrfs check`. Since this required reading sysfs files of
> scratch fses, did a bit of refactoring to make those checks target a
> device rather than assuming TEST_DEV.
>
> btrfs/301 depends on the kernel patchset:
> https://lore.kernel.org/linux-btrfs/cover.1694563454.git.boris@bur.io/
> and the btrfs-progs patchset:
> https://lore.kernel.org/linux-btrfs/cover.1695836680.git.boris@bur.io/
> (and config appropriate binaries to use squota-aware versions)
> ---
> Changelog:
> v4:
> - fix rescan helper bug
> - fix broken tab/spaces in squota helper
> - cleanup comments
> - improve test names, add some comments
> - switch to remount commit=1 for forcing cleaner
> - fix group list for 301
> - use reflink helpers
> - output errors to 301.out (and have expected ones there waiting)
> - cleanup "/dev/ksmg" writes I missed when grepping for /dev/kmsg
> - cleanup variable names
> - proper fio/btrfs/xfs_io requires
> - read nodesize from dump_super
> - sync before dump_tree
> - documented all calls to sync
> v3:
> - change btrfs/400 to btrfs/301
> v2:
> - new sysfs helpers in common
> - better gating for the new squota test
> - fix various formatting issues
> - get rid of noisy dmesg logging
>
>
> Boris Burkov (6):
> common: refactor sysfs_attr functions
> btrfs: quota mode helpers
> btrfs/301: new test for simple quotas
> btrfs: quota rescan helpers
> btrfs: use new rescan wrapper
> btrfs: skip squota incompatible tests
>
> common/btrfs | 56 ++++++
> common/rc | 127 ++++++++-----
> tests/btrfs/017 | 1 +
> tests/btrfs/022 | 1 +
> tests/btrfs/028 | 2 +-
> tests/btrfs/057 | 1 +
> tests/btrfs/091 | 3 +-
> tests/btrfs/104 | 2 +-
> tests/btrfs/123 | 2 +-
> tests/btrfs/126 | 2 +-
> tests/btrfs/139 | 2 +-
> tests/btrfs/153 | 2 +-
> tests/btrfs/171 | 6 +-
> tests/btrfs/179 | 2 +-
> tests/btrfs/180 | 2 +-
> tests/btrfs/190 | 2 +-
> tests/btrfs/193 | 2 +-
> tests/btrfs/210 | 2 +-
> tests/btrfs/224 | 6 +-
> tests/btrfs/230 | 2 +-
> tests/btrfs/232 | 2 +-
> tests/btrfs/301 | 435 ++++++++++++++++++++++++++++++++++++++++++++
> tests/btrfs/301.out | 18 ++
> 23 files changed, 615 insertions(+), 65 deletions(-)
> create mode 100755 tests/btrfs/301
> create mode 100644 tests/btrfs/301.out
>
All test cases modified here run fine on a system with PAGESIZE=64K,
except for btrfs/153 with and without MKFS_OPTIONS="-O squota".
btrfs/153 is successful on kernel v5.15 (I haven't tried other kernels)
btrfs/153 2s ... - output mismatch (see
/xfstests-dev/results//btrfs/153.out.bad)
--- tests/btrfs/153.out 2021-07-13 08:07:54.096971521 -0400
+++ /xfstests-dev/results//btrfs/153.out.bad 2023-09-30
05:33:53.560640258 -0400
@@ -1,2 +1,3 @@
QA output created by 153
+pwrite: Disk quota exceeded
Silence is golden
...
(Run 'diff -u /xfstests-dev/tests/btrfs/153.out
/xfstests-dev/results//btrfs/153.out.bad' to see the entire diff)
Thanks, Anand
next prev parent reply other threads:[~2023-09-30 9:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 23:16 [PATCH v4 0/6] btrfs: simple quotas fstests Boris Burkov
2023-09-28 23:16 ` [PATCH v4 1/6] common: refactor sysfs_attr functions Boris Burkov
2023-09-29 8:23 ` Anand Jain
2023-09-28 23:16 ` [PATCH v4 2/6] btrfs: quota mode helpers Boris Burkov
2023-09-29 8:57 ` Anand Jain
2023-09-29 9:11 ` Anand Jain
2023-09-28 23:16 ` [PATCH v4 3/6] btrfs/301: new test for simple quotas Boris Burkov
2023-09-28 23:16 ` [PATCH v4 4/6] btrfs: quota rescan helpers Boris Burkov
2023-09-29 9:14 ` Anand Jain
2023-09-28 23:16 ` [PATCH v4 5/6] btrfs: use new rescan wrapper Boris Burkov
2023-09-29 9:28 ` Anand Jain
2023-09-28 23:16 ` [PATCH v4 6/6] btrfs: skip squota incompatible tests Boris Burkov
2023-09-29 9:37 ` Anand Jain
2023-09-29 9:42 ` Anand Jain
2023-09-29 16:57 ` Boris Burkov
2023-09-29 17:28 ` Boris Burkov
2023-09-29 17:43 ` [PATCH] btrfs: fix rescan helper Boris Burkov
2023-09-30 9:37 ` Anand Jain
2023-09-30 9:45 ` Anand Jain [this message]
2023-10-05 8:08 ` [PATCH v4 0/6] btrfs: simple quotas fstests Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59124721-0e07-7b5f-d650-d58d9ce9fcb2@oracle.com \
--to=anand.jain@oracle.com \
--cc=boris@bur.io \
--cc=fstests@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).