Re: [PATCH v2 7/7] btrfs: change btrfs_fs_devices::rotating to bool

[Anand Jain <anand.jain@oracle.com>]

On 13/11/19 6:27 PM, Johannes Thumshirn wrote:
> struct btrfs_fs_devices::rotating currently is declared as an integer
> variable but only used as a boolean.
> 
> Change the variable definition to bool and update to code touching it to
> set 'true' and 'false'.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>


Reviewed-by: Anand Jain <anand.jain@oracle.com>

Thanks, Anand


> ---
>   fs/btrfs/volumes.c | 6 +++---
>   fs/btrfs/volumes.h | 2 +-
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index ce9c6fa3a32c..6d3bfea2e2d5 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -644,7 +644,7 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
>   
>   	q = bdev_get_queue(bdev);
>   	if (!blk_queue_nonrot(q))
> -		fs_devices->rotating = 1;
> +		fs_devices->rotating = true;
>   
>   	device->bdev = bdev;
>   	clear_bit(BTRFS_DEV_STATE_IN_FS_METADATA, &device->dev_state);
> @@ -2301,7 +2301,7 @@ static int btrfs_prepare_sprout(struct btrfs_fs_info *fs_info)
>   	fs_devices->num_devices = 0;
>   	fs_devices->open_devices = 0;
>   	fs_devices->missing_devices = 0;
> -	fs_devices->rotating = 0;
> +	fs_devices->rotating = false;
>   	fs_devices->seed = seed_devices;
>   
>   	generate_random_uuid(fs_devices->fsid);
> @@ -2496,7 +2496,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
>   	atomic64_add(device->total_bytes, &fs_info->free_chunk_space);
>   
>   	if (!blk_queue_nonrot(q))
> -		fs_devices->rotating = 1;
> +		fs_devices->rotating = true;
>   
>   	orig_super_total_bytes = btrfs_super_total_bytes(fs_info->super_copy);
>   	btrfs_set_super_total_bytes(fs_info->super_copy,
> diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
> index 8e9513b3fe9d..fc1b564b9cfe 100644
> --- a/fs/btrfs/volumes.h
> +++ b/fs/btrfs/volumes.h
> @@ -250,7 +250,7 @@ struct btrfs_fs_devices {
>   	/* set when we find or add a device that doesn't have the
>   	 * nonrot flag set
>   	 */
> -	int rotating;
> +	bool rotating;
>   
>   	struct btrfs_fs_info *fs_info;
>   	/* sysfs kobjects */
>