From: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
To: dsterba@suse.cz, Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>,
linux-btrfs@vger.kernel.org, dsterba@suse.com
Subject: Re: [PATCH] btrfs-progs: add option to run balance as daemon
Date: Tue, 26 Jul 2016 13:25:12 -0400 [thread overview]
Message-ID: <5a84933a-1990-f1f8-ede1-5af9e54a0d88@gmail.com> (raw)
In-Reply-To: <20160726170739.GM30795@twin.jikos.cz>
On 2016-07-26 13:07, David Sterba wrote:
> On Mon, Jul 11, 2016 at 10:44:30AM +0900, Satoru Takeuchi wrote:
>>> + chdir("/");
>>
>> You should check the return value of chdir(). Otherwise
>> we get the following warning message at the build time.
>
> Can we actually fail to change directory to '/' ? Otherwise I think the
> warning should be silenced so the build is clean.
It is theoretically possible, but in practice it means you either have
failing hardware or your kernel is broken somehow, both of which should
be causing all kinds of other issues, and thus we don't really gain
anything from trying to catch the error.
next prev parent reply other threads:[~2016-07-26 17:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 15:16 [PATCH] btrfs-progs: add option to run balance as daemon Austin S. Hemmelgarn
2016-07-11 1:44 ` Satoru Takeuchi
2016-07-26 17:07 ` David Sterba
2016-07-26 17:25 ` Austin S. Hemmelgarn [this message]
2016-07-11 7:26 ` Tomasz Torcz
2016-07-11 11:17 ` Austin S. Hemmelgarn
2016-07-11 16:58 ` Tomasz Torcz
2016-07-12 12:25 ` Austin S. Hemmelgarn
2016-07-12 15:22 ` Duncan
2016-07-12 18:25 ` Austin S. Hemmelgarn
2016-07-13 4:39 ` Andrei Borzenkov
2016-07-13 11:57 ` Austin S. Hemmelgarn
2016-07-13 16:38 ` David Sterba
2016-07-13 16:59 ` Austin S. Hemmelgarn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a84933a-1990-f1f8-ede1-5af9e54a0d88@gmail.com \
--to=ahferroin7@gmail.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=takeuchi_satoru@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).