linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, David Sterba <dsterba@suse.cz>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: Timeline or roadmap to split lowmem mode and original mode check?
Date: Wed, 17 Jan 2018 12:55:28 +0200	[thread overview]
Message-ID: <5d120b10-8d25-9caa-5086-c417a7b8e715@suse.com> (raw)
In-Reply-To: <521779a7-60bc-c7c9-b35d-77c5e36aaacc@gmx.com>



On 17.01.2018 07:32, Qu Wenruo wrote:
> Hi David,
> 
> There is the long planned work to split the original mode and lowmem
> mode check into their own .[ch] files.
> 
> I found it harder and harder to locate repair functions for original and
> lowmem mode when writing fixes for them.
> 
> I wonder if it's a good time to start the split work, and if you're OK
> with it, my plan is to:
> 
> 1) Start the split work based on 4.14.1
> 
> 2) Split check code into:
>    check/common.[ch]	<<< Not sure how many functions will be there
>    check/lowmem.[ch]
>    check/origin.[ch]
>    check/main.c
> 
> Currently most fsck fixes and enhancement are from Fujitsu guys who I'm
> quite familiar with, so rebasing their code won't be a big problem for me.
> 
> If this works for you, I can start the work asap.

When you start working on that you might consider also documenting most
of the repair functions :)

> 
> Thanks,
> Qu
> 

      reply	other threads:[~2018-01-17 10:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17  5:32 Timeline or roadmap to split lowmem mode and original mode check? Qu Wenruo
2018-01-17 10:55 ` Nikolay Borisov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d120b10-8d25-9caa-5086-c417a7b8e715@suse.com \
    --to=nborisov@suse.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).