From: Nikolay Borisov <nborisov@suse.com>
To: Timofey Titovets <nefelim4ag@gmail.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
herbert@gondor.apana.org.au
Subject: Re: [PATCH 0/2] Remove custom crc32c init code from btrfs
Date: Mon, 8 Jan 2018 14:30:01 +0200 [thread overview]
Message-ID: <5deadae2-3b0f-0a8e-e271-e53856af8810@suse.com> (raw)
In-Reply-To: <CAGqmi771dsWiAJC8=xYn+cvkNoCaTA9uzosrAAhfp9ABxR9+bg@mail.gmail.com>
On 8.01.2018 12:21, Timofey Titovets wrote:
> 2018-01-08 12:45 GMT+03:00 Nikolay Borisov <nborisov@suse.com>:
>> So here is a small 2 patch set which removes btrfs' manual initialisation of
>> the lower level crc32c module. Explanation why is ok can be found in Patch 2/2.
>>
>> Patch 1/2 just adds a function to the generic crc32c header which allows
>> querying the actual crc32c implementaiton used (i.e. software or hw-accelerated)
>> to retain current btrfs behavior. This is mainly used for debugging purposes
>> and is independent.
>>
>> Nikolay Borisov (2):
>> libcrc32c: Add crc32c_impl function
>> btrfs: Remove custom crc32c init code
>>
>> fs/btrfs/Kconfig | 3 +--
>> fs/btrfs/Makefile | 2 +-
>> fs/btrfs/check-integrity.c | 4 ++--
>> fs/btrfs/ctree.h | 16 ++++++++++++++
>> fs/btrfs/dir-item.c | 1 -
>> fs/btrfs/disk-io.c | 4 ++--
>> fs/btrfs/extent-tree.c | 10 ++++-----
>> fs/btrfs/hash.c | 54 ----------------------------------------------
>> fs/btrfs/hash.h | 43 ------------------------------------
>> fs/btrfs/inode-item.c | 1 -
>> fs/btrfs/inode.c | 1 -
>> fs/btrfs/props.c | 2 +-
>> fs/btrfs/send.c | 4 ++--
>> fs/btrfs/super.c | 14 ++++--------
>> fs/btrfs/tree-log.c | 2 +-
>> include/linux/crc32c.h | 1 +
>> lib/libcrc32c.c | 6 ++++++
>> 17 files changed, 42 insertions(+), 126 deletions(-)
>> delete mode 100644 fs/btrfs/hash.c
>> delete mode 100644 fs/btrfs/hash.h
>>
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Reviewed-by: Timofey Titovets <nefelim4ag@gmail.com>
>
> P.S.
> May that are overkill to remove hash.c completely?
> i.e. if we have a "plan" to support another hash algo,
> we still need some abstractions for that.
NAK.
Btrfs' code base has seen way too many instances of people dumping code
"in anticipation of feature X", only to result in said feature never
materializing. The end result is cruft being added. When/if someones
decides to add a new checksum algo they will have to account for the
existing crc32c and come up with appropriate abstraction. Until (if at
all) that time comes - we don't need any of the hash.[ch] stuff.
>
> Inband dedup don't touch hash.* so, no one else must be affected.
>
> Thanks.
>
next prev parent reply other threads:[~2018-01-08 12:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 9:45 [PATCH 0/2] Remove custom crc32c init code from btrfs Nikolay Borisov
2018-01-08 9:45 ` [PATCH 1/2] libcrc32c: Add crc32c_impl function Nikolay Borisov
2018-02-02 17:29 ` David Sterba
2018-02-03 9:51 ` Herbert Xu
2018-01-08 9:45 ` [PATCH 2/2] btrfs: Remove custom crc32c init code Nikolay Borisov
2018-02-02 17:17 ` David Sterba
2018-02-02 19:46 ` Andy Shevchenko
2018-02-05 22:53 ` David Sterba
2018-01-08 10:21 ` [PATCH 0/2] Remove custom crc32c init code from btrfs Timofey Titovets
2018-01-08 12:30 ` Nikolay Borisov [this message]
2018-02-05 22:59 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5deadae2-3b0f-0a8e-e271-e53856af8810@suse.com \
--to=nborisov@suse.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nefelim4ag@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).