From: Nikolay Borisov <nborisov@suse.com>
To: Johannes Thumshirn <jthumshirn@suse.de>, linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH 2/6] btrfs: Change submit_bio_hook to taking an inode directly
Date: Thu, 11 Apr 2019 14:23:40 +0300 [thread overview]
Message-ID: <5dec46a5-468e-e6b7-8dae-d458ec40543e@suse.com> (raw)
In-Reply-To: <6473ad5d-3404-a6e3-3031-11760fa348a4@suse.de>
On 11.04.19 г. 14:18 ч., Johannes Thumshirn wrote:
> On 10/04/2019 16:24, Nikolay Borisov wrote:
>> The only possible 'private_data' that is passed to this function is
>> actually an inode. Make that explicit by changing the signature of the
>> call back. No functional changes.
>
> Can't we change struct extent_io_tree::private_data and
> extent_io_tree_init(..., void *private_data) to be an inode as well?
>
> If I didn't overlook something we always pass in an inode or NULL.
You are right, latest refactoring I did made it so. I can send patches
atop this series.
David, how do you like to organise this? Resend the series with 2 more
patches in it or shall I send them as separate once this lands?
>
next prev parent reply other threads:[~2019-04-11 11:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 14:24 [PATCH 0/6] Simplifications around submit_bio_hook Nikolay Borisov
2019-04-10 14:24 ` [PATCH 1/6] btrfs: Define submit_bio_hook's type directly Nikolay Borisov
2019-04-11 11:10 ` Johannes Thumshirn
2019-04-10 14:24 ` [PATCH 2/6] btrfs: Change submit_bio_hook to taking an inode directly Nikolay Borisov
2019-04-11 11:18 ` Johannes Thumshirn
2019-04-11 11:23 ` Nikolay Borisov [this message]
2019-04-10 14:24 ` [PATCH 3/6] btrfs: Remove 'tree' argument from read_extent_buffer_pages Nikolay Borisov
2019-04-11 13:01 ` Johannes Thumshirn
2019-04-10 14:24 ` [PATCH 4/6] btrfs: Pass 0 for bio_offset to btrfs_wq_submit_bio Nikolay Borisov
2019-04-11 13:09 ` Johannes Thumshirn
2019-04-11 13:10 ` Johannes Thumshirn
2019-04-11 13:17 ` Nikolay Borisov
2019-04-11 13:26 ` Johannes Thumshirn
2019-04-10 14:24 ` [PATCH 5/6] btrfs: Always pass 0 bio_offset for btree_submit_bio_start Nikolay Borisov
2019-04-11 13:27 ` Johannes Thumshirn
2019-04-10 14:24 ` [PATCH 6/6] btrfs: Remove bio_offset argument from submit_bio_hook Nikolay Borisov
2019-04-10 16:39 ` Nikolay Borisov
2019-04-10 16:46 ` [PATCH v2] " Nikolay Borisov
2019-04-11 13:29 ` Johannes Thumshirn
2019-04-11 14:39 ` Nikolay Borisov
2019-04-18 13:04 ` [PATCH 0/6] Simplifications around submit_bio_hook David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dec46a5-468e-e6b7-8dae-d458ec40543e@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.cz \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).