From: Nikolay Borisov <nborisov@suse.com>
To: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 3/8] btrfs: move btrfs_scratch_superblocks into btrfs_dev_replace_finishing
Date: Fri, 21 Aug 2020 15:56:29 +0300 [thread overview]
Message-ID: <5e1d0081-df24-2af1-3a16-232c8c83481f@suse.com> (raw)
In-Reply-To: <f057e5076450f399e87cf54c3951bb2033febe36.1597936173.git.josef@toxicpanda.com>
On 20.08.20 г. 18:18 ч., Josef Bacik wrote:
> We need to move the closing of the src_device out of all the device
> replace locking, but we definitely want to zero out the superblock
> before we commit the last time to make sure the device is properly
> removed. Handle this by pushing btrfs_scratch_superblocks into
> btrfs_dev_replace_finishing, and then later on we'll move the src_device
> closing and freeing stuff where we need it to be.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2020-08-21 12:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 15:18 [PATCH 0/8] Lockdep fixes Josef Bacik
2020-08-20 15:18 ` [PATCH 1/8] btrfs: drop path before adding new uuid tree entry Josef Bacik
2020-08-20 15:18 ` [PATCH 2/8] btrfs: fix potential deadlock in the search ioctl Josef Bacik
2020-08-20 15:18 ` [PATCH 3/8] btrfs: move btrfs_scratch_superblocks into btrfs_dev_replace_finishing Josef Bacik
2020-08-21 12:56 ` Nikolay Borisov [this message]
2020-08-20 15:18 ` [PATCH 4/8] btrfs: move btrfs_rm_dev_replace_free_srcdev outside of all locks Josef Bacik
2020-08-20 15:18 ` [PATCH 5/8] btrfs: do not hold device_list_mutex when closing devices Josef Bacik
2020-08-20 15:18 ` [PATCH 6/8] btrfs: allocate scrub workqueues outside of locks Josef Bacik
2020-08-20 15:18 ` [PATCH 7/8] btrfs: set the correct lockdep class for new nodes Josef Bacik
2020-08-21 13:36 ` Nikolay Borisov
2020-08-20 15:18 ` [PATCH 8/8] btrfs: set the lockdep class for log tree extent buffers Josef Bacik
2020-08-21 13:43 ` Nikolay Borisov
2020-08-26 10:50 ` [PATCH 0/8] Lockdep fixes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e1d0081-df24-2af1-3a16-232c8c83481f@suse.com \
--to=nborisov@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox