From: Anand Jain <anand.jain@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs: warn for num_devices below 0
Date: Fri, 13 Jul 2018 19:05:27 +0800 [thread overview]
Message-ID: <5fd2a33f-f9a0-00a6-ebc1-9cf8cb7dec8d@oracle.com> (raw)
In-Reply-To: <8a7b78aa-1a7f-9edd-e30b-d97d15a35331@suse.com>
On 07/12/2018 03:13 PM, Nikolay Borisov wrote:
>
>
> On 10.07.2018 21:22, Anand Jain wrote:
>> In preparation to de-duplicate a section of code where we deduce the
>> num_devices, use warn instead of bug.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>> fs/btrfs/volumes.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>> index eb78bb8d1108..ce6faeb8bcf8 100644
>> --- a/fs/btrfs/volumes.c
>> +++ b/fs/btrfs/volumes.c
>> @@ -3813,7 +3813,7 @@ int btrfs_balance(struct btrfs_fs_info *fs_info,
>> num_devices = fs_info->fs_devices->num_devices;
>> btrfs_dev_replace_read_lock(&fs_info->dev_replace);
>> if (btrfs_dev_replace_is_ongoing(&fs_info->dev_replace)) {
>> - BUG_ON(num_devices < 1);
>> + WARN_ON(num_devices < 1);
> Isn't dev_replace_is_ongoing && num_devices < 1 indeed a logical bug
> situation? Under what condition can it happen that you deem "non
> critical" ?
In all conditions needs least one device for the FS to be mounted.
In fact we can just remove it.
Thanks, Anand
>> num_devices--;
>> }
>> btrfs_dev_replace_read_unlock(&fs_info->dev_replace);
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2018-07-13 11:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 18:22 [PATCH 1/3] btrfs: warn for num_devices below 0 Anand Jain
2018-07-10 18:22 ` [PATCH 2/3] btrfs: add helper btrfs_num_devices() to deduce num_devices Anand Jain
2018-07-12 7:31 ` Nikolay Borisov
2018-07-13 11:17 ` Anand Jain
2018-07-13 11:17 ` Nikolay Borisov
2018-07-16 5:17 ` Anand Jain
2018-07-10 18:22 ` [PATCH 3/3] btrfs: add helper function check device delete able Anand Jain
2018-07-12 7:43 ` Nikolay Borisov
2018-07-13 11:27 ` Anand Jain
2018-07-13 11:28 ` Nikolay Borisov
2018-07-16 5:14 ` Anand Jain
2018-07-12 7:13 ` [PATCH 1/3] btrfs: warn for num_devices below 0 Nikolay Borisov
2018-07-13 11:05 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fd2a33f-f9a0-00a6-ebc1-9cf8cb7dec8d@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).