From: Eric Sandeen <sandeen@redhat.com>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>,
"Wang Shilong" <wangshilong1991@gmail.com>,
linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz
Subject: Re: [PATCH] btrfs-progs: du: fix to skip not btrfs dir/file
Date: Wed, 6 Jul 2016 21:43:12 -0500 [thread overview]
Message-ID: <606f0245-68b6-587f-eb2c-7044144af83d@redhat.com> (raw)
In-Reply-To: <577D091F.6020407@applied-asynchrony.com>
On 7/6/16 8:35 AM, Holger Hoffstätte wrote:
> On 07/06/16 14:25, Wang Shilong wrote:
...
>> After patch, it will look like:
>> Total Exclusive Set shared Filename
>> skipping not btrfs dir/file: boot
>> skipping not btrfs dir/file: dev
>> skipping not btrfs dir/file: proc
>> skipping not btrfs dir/file: run
>> skipping not btrfs dir/file: sys
>> 0.00B 0.00B - //root/.bash_logout
>> 0.00B 0.00B - //root/.bash_profile
>> 0.00B 0.00B - //root/.bashrc
>> 0.00B 0.00B - //root/.cshrc
>> 0.00B 0.00B - //root/.tcshrc
>>
>> This works for me to analysis system usage and analysis
>> performaces.
>
> This is great, but can we please skip the "skipping .." messages?
> Maybe it's just me but I really don't see the value of printing them
> when they don't contribute to the result.
> They also mess up the display. :)
<driveby>
I agree, those messages add no value.
</driveby>
-Eric
> thanks,
> Holger
prev parent reply other threads:[~2016-07-07 2:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 12:25 [PATCH] btrfs-progs: du: fix to skip not btrfs dir/file Wang Shilong
2016-07-06 13:35 ` Holger Hoffstätte
2016-07-06 15:16 ` Wang Shilong
2016-07-06 15:20 ` Hugo Mills
2016-07-06 15:42 ` Holger Hoffstätte
2016-07-06 15:56 ` Hugo Mills
2016-07-11 10:20 ` David Sterba
2016-07-07 2:43 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=606f0245-68b6-587f-eb2c-7044144af83d@redhat.com \
--to=sandeen@redhat.com \
--cc=dsterba@suse.cz \
--cc=holger@applied-asynchrony.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).